tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mladen Turk <mt...@apache.org>
Subject Re: svn commit: r998120 - /tomcat/jk/trunk/native/common/jk_connect.c
Date Sat, 25 Sep 2010 14:08:08 GMT
On 09/25/2010 03:00 PM, Rainer Jung wrote:
> On 17.09.2010 15:26, mturk@apache.org wrote:
>> Author: mturk
>> Date: Fri Sep 17 13:26:58 2010
>> New Revision: 998120
>>
>> URL: http://svn.apache.org/viewvc?rev=998120&view=rev
>> Log:
>> Make sure errno survives JK_TRACE_EXIT call
>
> Good catch!
>
> WDYT about
>
> Index: common/jk_logger.h
> ===================================================================
> --- common/jk_logger.h (revision 1001201)
> +++ common/jk_logger.h (working copy)
> @@ -115,7 +115,9 @@
> #define JK_TRACE_EXIT(l) \
> do { \
> if ((l) && (l)->level == JK_LOG_TRACE_LEVEL) { \
> + int tmp_errno = errno;
> jk_log((l), JK_LOG_TRACE, "exit"); \
> + errno = tmp_errno;
> } } while (0)
>
> #endif /* JK_PRODUCTION */
>
> to handle that in general. It only runs additional code when trace is on and is a bit
more general. If you like it, I can apply and redo some of the above changes.
>

Sure, this would make it event better.


Regards
-- 
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message