Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (nike.apache.org: domain of knst.kolinko@gmail.com
 designates 209.85.214.45 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=EZm1Kys67Kr3PDoxo0pFR/OQHYm9n8NzXK5P1ha3zjam4CiUpnMUCPViStdthaDhAV
         ugZcete2I5zs+qy54iJd1aS5qWJmOgfmeC1UIGAfTwRXa8AbdvnET4rQ2gYXRLzDbe0m
         zJYV5HbWhOnTO2bA7WymzwPtkbVDbfSYzCA8k=
MIME-Version: 1.0
In-Reply-To: <4C331D39.7070804@apache.org>
References: <20100706104016.54DAE23888E4@eris.apache.org>
	<4C331D39.7070804@apache.org>
Date: Wed, 7 Jul 2010 14:36:07 +0400
Message-ID: <AANLkTimWdoypxkPU73djawWf34CLx2RO4aW0uHgTeHLJ@mail.gmail.com>
Subject: Re: svn commit: r960864 - /tomcat/tc6.0.x/trunk/STATUS.txt
From: Konstantin Kolinko <knst.kolinko@gmail.com>
To: Tomcat Developers List <dev@tomcat.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

2010/7/6 Mark Thomas <markt@apache.org>:
> On 06/07/2010 12:40, kkolinko@apache.org wrote:
>>
>> Author: kkolinko
>> Date: Tue Jul =A06 10:40:16 2010
>> New Revision: 960864
>>
>> URL: http://svn.apache.org/viewvc?rev=3D960864&view=3Drev
>> Log:
>> vote
>>
>> Modified:
>> =A0 =A0 tomcat/tc6.0.x/trunk/STATUS.txt
>>
>> Modified: tomcat/tc6.0.x/trunk/STATUS.txt
>> URL:
>> http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=3D96086=
4&r1=3D960863&r2=3D960864&view=3Ddiff
>>
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>> --- tomcat/tc6.0.x/trunk/STATUS.txt (original)
>> +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Jul =A06 10:40:16 2010
>> @@ -154,11 +154,14 @@ PATCHES PROPOSED TO BACKPORT:
>> =A0* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=3D49551
>> =A0 =A0Allow default context.xml file to be specified using an absolute =
path
>> =A0 =A0http://svn.apache.org/viewvc?rev=3D960701&view=3Drev
>> - =A0+1: markt
>> + =A0+1: markt, kkolinko
>> =A0 =A0-1:
>>
>> =A0* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=3D49217
>> =A0 =A0Prevent use of Java keywords in EL identifiers
>> =A0 =A0http://svn.apache.org/viewvc?rev=3D960711&view=3Drev
>> =A0 =A0+1: markt
>> - =A0-1:
>> + =A0-1: kkolinko: r960711 is a testcase, the fix is in r960712
>> + =A0 Regarding r960712 I am -1 because 1) the list of reserved keywords
>> must be shorter,
>> + =A0 as I mentioned in Comment #3 for the issue and 2) it might break
>> existing applications,
>
> That analysis is not correct. Java identifier is defined by the Java
> language spec, not the EL spec.
>

I still think that

1) There is no direct example/evidence in the EL spec itself,
and I understand that TCK passes without a fix for BZ 49217,
because we have released 6.0.26 and 7.0.0

2) There is a separate chapter "Reserved Words" in EL spec,
which explicitly lists words that are forbidden as identifiers.

It is not mentioned there that Java language keywords are
also reserved.

It explicitly mentions "instanceof" which is already a Java keyword,
as well as mentions "true", "false" and "null".

3) I agree, that it is possible to read the spec in your way,
so it makes sense to have such a check,
but I think that there must be a way to turn it off.


Re:
  https://issues.apache.org/bugzilla/attachment.cgi?id=3D25726
The patch is incomplete. The "SKIP_IDENTIFIER_CHECK" property is mentioned
in documentation only. It is not used in the code.


>> + =A0 so I think it must be possible to turn this check off.
>
> Agreed. I'll propose a back-port with an option to disable once I have
> implemented all of the restrictions in the JLS.
>
> Mark
>
>

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org