Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: neutral (nike.apache.org: local policy)
Message-ID: <4B312B9F.7010107@apache.org>
Date: Tue, 22 Dec 2009 20:27:11 +0000
From: Mark Thomas <markt@apache.org>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-GB;
 rv:1.9.1.5) Gecko/20091204 Thunderbird/3.0
MIME-Version: 1.0
To: Tomcat Developers List <dev@tomcat.apache.org>
Subject: Re: [VOTE] Release build 6.0.21 (try 2)
References: <4B30EFB5.8020507@gmail.com>
In-Reply-To: <4B30EFB5.8020507@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

On 22/12/2009 16:11, jean-frederic clere wrote:
> The candidates binaries are available here:
> http://people.apache.org/~jfclere/tomcat-6/v6.0.21-try2/
>
> According to the release process, the 6.0.21 tag is:
> [X] Broken
> [ ] Alpha
> [ ] Beta
> [ ] Stable
>
> The differences are only the tcnative windows binary files: tcnative was
> broken in the previous try.

Source files:
src.tar.gz == src.zip
MD5s match
Signatures good
Key in ASF web of trust

All the source files have linux line-endings. I think this is a
side-effect of building on linux rather than Windows and has been this
way for the last few releases. There is a patch proposed to fix this but
I don't view this as a show stopper.

There is also a difference between the tag and the source files. The
diff is:
---
D:/repos/asf/public/tomcat/tc6.0.x/tags/TOMCAT_6_0_21/build.properties.default
Tue Dec 22 17:10:53 2009
+++
D:/tmp/apache-tomcat-6.0.21-src-zip/apache-tomcat-6.0.21-src/build.properties.default
Tue Dec 22 17:31:18 2009
@@ -44,7 +44,7 @@
 compile.debug=true

 base-commons.loc=http://archive.apache.org/dist/commons
-base-tomcat.loc=http://archive.apache.org/dist/tomcat
+base-tomcat.loc=http://people.apache.org/~jfclere/
 base-sf.loc=http://downloads.sourceforge.net

 # ----- Commons Logging, version 1.1 or later -----

I assume this was done to include the desired windows binaries. However,
this means that anyone trying to build from the src distro will be
pulling the Windows binaries from the wrong place. The correct way to do
this would have been to create a build.properties file and override the
base-tomcat.loc setting in that file.

The tag is correct, the source bundles just need re-building from the tag.

Binaries:
apache-tomcat-6.0.21.zip.md5 is broken. If lists multiple files but the
MD5 is only correct for the first file in the list. The root cause is a
copy and paster error in the build file (patch already proposed to fix
it). Applying this fix would mean a re-tag. However, I'd be happy with
manually fixing the generated MD5s to fix this to save the re-tag.

Servlet TCK passes
JSP TCK passes - 1 failure

This one, however, can't be ignored. Remy hinted at it early today. The
fix for bug 47453 created a regression in that the constraint expressed
in JSP.2.3.4 namely that <quote>A String literal can be provided, as
long as the return type of the deferred method signature is not
void</quote> is not enforced. This needs to be fixed for 6.0.21 and
will, therefore, require a re-tag.

I am starting to look at this now.

Since we are going to have to re-tag anyway, it would be good if the
patches required to fix the various niggles above were applied before
the tag.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org