Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 5857 invoked from network); 17 Dec 2009 23:00:18 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 17 Dec 2009 23:00:18 -0000 Received: (qmail 85364 invoked by uid 500); 17 Dec 2009 23:00:17 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 85264 invoked by uid 500); 17 Dec 2009 23:00:17 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 85253 invoked by uid 99); 17 Dec 2009 23:00:17 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Dec 2009 23:00:17 +0000 X-ASF-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00 X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [72.22.94.67] (HELO virtual.halosg.com) (72.22.94.67) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Dec 2009 23:00:08 +0000 Received: (qmail 30343 invoked from network); 17 Dec 2009 16:59:47 -0600 Received: from 38-171-19-72.skybeam.com (HELO ?192.168.3.122?) (72.19.171.38) by halosg.com with (DHE-RSA-AES256-SHA encrypted) SMTP; 17 Dec 2009 16:59:47 -0600 Message-ID: <4B2AB819.9030603@hanik.com> Date: Thu, 17 Dec 2009 16:00:41 -0700 From: Filip Hanik - Dev Lists User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Lightning/1.0pre Thunderbird/3.0b3 MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: [Tomcat6] Eclipse warnings References: <25aac9fc0912161231j601b88a3tc99b1cb9b68b059c@mail.gmail.com> <4B2A5072.6000800@apache.org> In-Reply-To: <4B2A5072.6000800@apache.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 12/17/2009 08:38 AM, Mark Thomas wrote: > On 16/12/2009 21:31, sebb wrote: > >> Eclipse generates many thousands of warnings for the Tomcat6 code. >> >> For example, over 2000 missing @Override markers, over 3000 "raw type" warnings. >> >> Is it the intention to fix these (eventually)? >> > Speaking personally, I have no intention of spending any time on these > at all. There are more important things to fix, like actual bugs, than > these cosmetic changes. > I'd also -1 any cosmetic changes, since they make troubleshooting really hard after the SVN diffs no longer come out clean, but have potentially thousands of changed lines. I would consider that a technical veto for a change that brings close to no value. Filip > Mark > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org > For additional commands, e-mail: dev-help@tomcat.apache.org > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org