Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 69036 invoked from network); 19 Nov 2009 00:51:05 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 19 Nov 2009 00:51:05 -0000 Received: (qmail 36128 invoked by uid 500); 19 Nov 2009 00:51:04 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 36020 invoked by uid 500); 19 Nov 2009 00:51:04 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 36009 invoked by uid 99); 19 Nov 2009 00:51:04 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Nov 2009 00:51:04 +0000 X-ASF-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [193.252.22.192] (HELO smtp6.freeserve.com) (193.252.22.192) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Nov 2009 00:51:02 +0000 Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf3623.me.freeserve.com (SMTP Server) with ESMTP id 489017000086 for ; Thu, 19 Nov 2009 01:50:40 +0100 (CET) Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf3623.me.freeserve.com (SMTP Server) with ESMTP id 3B7697000087 for ; Thu, 19 Nov 2009 01:50:40 +0100 (CET) Received: from mx01.dev.local (unknown [91.109.166.197]) by mwinf3623.me.freeserve.com (SMTP Server) with ESMTP id 18A2E7000086 for ; Thu, 19 Nov 2009 01:50:40 +0100 (CET) X-ME-UUID: 20091119005040101.18A2E7000086@mwinf3623.me.freeserve.com Received: from localhost (localhost [127.0.0.1]) by mx01.dev.local (Postfix) with ESMTP id F254432411 for ; Thu, 19 Nov 2009 00:50:51 +0000 (GMT) X-Virus-Scanned: Debian amavisd-new at homeinbox.net Received: from mx01.dev.local ([127.0.0.1]) by localhost (mx01.dev.local [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UWHJ+YkDaYYA for ; Thu, 19 Nov 2009 00:50:49 +0000 (GMT) Received: from [192.168.0.9] (study03.dev.local [192.168.0.9]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx01.dev.local (Postfix) with ESMTPSA id 4A86E323E7 for ; Thu, 19 Nov 2009 00:50:49 +0000 (GMT) Message-ID: <4B049659.3060801@apache.org> Date: Thu, 19 Nov 2009 00:50:33 +0000 From: Mark Thomas User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: svn commit: r882008 - /tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java References: <20091118235424.E3C18238887A@eris.apache.org> <427155180911181613v2b35a56j800b2fd8e7e09577@mail.gmail.com> <4B048F1B.4060003@apache.org> <427155180911181641x363ad69qd30e6ce3bca9c02e@mail.gmail.com> In-Reply-To: <427155180911181641x363ad69qd30e6ce3bca9c02e@mail.gmail.com> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Konstantin Kolinko wrote: > 2009/11/19 Mark Thomas : >> Konstantin Kolinko wrote: >>> twice the same condition >> Thanks - I'll fix that. >> > > OK, seen that. > > On second thought: > it is strange to synchronize on "this" to set a static field. That should be > synchronized(getClass()) Fair point, although I doubt this code is ever actually called in Tomcat... Fixed. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org