Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 86572 invoked from network); 11 Jun 2009 21:32:27 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 11 Jun 2009 21:32:27 -0000 Received: (qmail 27954 invoked by uid 500); 11 Jun 2009 21:32:38 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 27881 invoked by uid 500); 11 Jun 2009 21:32:38 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 27718 invoked by uid 99); 11 Jun 2009 21:32:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jun 2009 21:32:37 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of knst.kolinko@gmail.com designates 209.85.218.225 as permitted sender) Received: from [209.85.218.225] (HELO mail-bw0-f225.google.com) (209.85.218.225) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jun 2009 21:32:29 +0000 Received: by bwz25 with SMTP id 25so2060171bwz.0 for ; Thu, 11 Jun 2009 14:32:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=rpPk7sIJVUzUlN1Esydgjoz2HUfVVOIVb2eJGbq0nkw=; b=sNWgk8DzCkHavF6FEySlnBFBMAG4dTiORRjqRzYYZNQT76e9d88XCXEF/i9+2sHak+ 8GQ8M+d4/xw5JXUSvUvU0MNSAC1yZvSJp3IZmgHrqPuR5TgIQDVTjFcRMj7I3fraWhN3 jcyvvGn0B4/sEWSMok2kQWKZPy4+bfUKeoiHE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=HL67q7CW6xhrXPOA+e+zS8Nbayq/WqHILP6SHmudghk9S6mmWVOmsr89/O1hW8LyGT U1/8ZK53oWCb12HBKIP1J+9I9lzINOkuJV+mzAqQZcRF2IwBzrQc0+ChSHR/do7aklHJ mLVzr5Zt1jxdWwLtR/LSEjP6uJam76UTSvJ68= MIME-Version: 1.0 Received: by 10.103.223.2 with SMTP id a2mr1511267mur.54.1244755928209; Thu, 11 Jun 2009 14:32:08 -0700 (PDT) In-Reply-To: <4A315DD0.8070706@apache.org> References: <20090610233458.049422388882@eris.apache.org> <4A312988.2040000@apache.org> <427155180906111041j32807c5ap7868bfd210902e27@mail.gmail.com> <4A315DD0.8070706@apache.org> Date: Fri, 12 Jun 2009 01:32:08 +0400 Message-ID: <427155180906111432h449f2deg7505055d6d202f2@mail.gmail.com> Subject: Re: svn commit: r783570 - /tomcat/current/tc4.1.x/STATUS.txt From: Konstantin Kolinko To: Tomcat Developers List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Thank you for detailed explanation. My analysis is the following: hres.setLocale(locale); call -> o.a.c.Response.setLocale() -> o.a.c.connector.ResponseBase.setLocale() In o.a.c.connector.ResponseBase.setLocale() it calls CharsetMapper.getCharset(locale) and updates the contentType header. The problem is with those locales for which CharsetMapper.getCharset(locale) returns null. There is an error in ResponseBase.setLocale() that it will set contentType = contentType + ";charset=null" in those cases. How about fixing that? My understanding is that it will solve the issue, and won't change the error page encoding for existing applications. We cannot fix CharsetMapper, because it can be overwritten, but we can fix those places where it is called. Here is the patch: http://people.apache.org/~kkolinko/patches/2009-06-12_tc41_CharsetMapper.patch Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org