From dev-return-96416-apmail-tomcat-dev-archive=tomcat.apache.org@tomcat.apache.org Fri Jun 12 15:29:58 2009 Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 68395 invoked from network); 12 Jun 2009 15:29:58 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 12 Jun 2009 15:29:58 -0000 Received: (qmail 79537 invoked by uid 500); 12 Jun 2009 15:30:09 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 79470 invoked by uid 500); 12 Jun 2009 15:30:09 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 79459 invoked by uid 99); 12 Jun 2009 15:30:08 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Jun 2009 15:30:08 +0000 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [193.252.22.128] (HELO smtp5.freeserve.com) (193.252.22.128) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Jun 2009 15:29:59 +0000 Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf3418.me.freeserve.com (SMTP Server) with ESMTP id B9C421C00084 for ; Fri, 12 Jun 2009 17:29:37 +0200 (CEST) Received: from smtp.homeinbox.net (unknown [91.109.186.196]) by mwinf3418.me.freeserve.com (SMTP Server) with ESMTP id C3E191C00082 for ; Fri, 12 Jun 2009 17:29:35 +0200 (CEST) X-ME-UUID: 20090612152935802.C3E191C00082@mwinf3418.me.freeserve.com Received: from localhost (localhost [127.0.0.1]) by smtp.homeinbox.net (Postfix) with ESMTP id AF6461A4D55 for ; Fri, 12 Jun 2009 16:29:32 +0100 (BST) X-Virus-Scanned: Debian amavisd-new at homeinbox.net Received: from smtp.homeinbox.net ([127.0.0.1]) by localhost (server01.dev.local [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E9BFyPJ6Ysmp for ; Fri, 12 Jun 2009 16:29:29 +0100 (BST) Received: from [192.168.0.9] (study03.dev.local [192.168.0.9]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.homeinbox.net (Postfix) with ESMTPSA id 7E2261A40D6 for ; Fri, 12 Jun 2009 16:29:29 +0100 (BST) Message-ID: <4A327452.4090303@apache.org> Date: Fri, 12 Jun 2009 16:29:22 +0100 From: Mark Thomas User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: svn commit: r784083 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/naming/resources/ webapps/docs/config/ References: <20090612113830.042492388896@eris.apache.org> <4A32498D.50708@apache.org> In-Reply-To: <4A32498D.50708@apache.org> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Tim Funk wrote: > > Typo: I'll fix that. > 1) Does the adding and removing of aliases need to be thread safe? Using > ConcurrentHashMap instead of > HashMap I don't think so. It only gets called once when the context is first initialised which is single threaded. It doesn't even get called on re-load. If we make DirContext configuration more dynamic then, yes we'd need to look at this and probably a whole bunch of other stuff. > 2) For public void addAlias(String path, BaseDirContext dirContext) { > Do we want to disallow / as the path? Or let the foot shooting be allowed? We let people use it for docBase so I'm happy to let them do the same here. > 3) public void setAliases(String theAliases) > If the file is not a directory (or does not exist) - we should do > something. I'll add some more error trapping. Thanks for the feedback. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org