Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 70972 invoked from network); 22 May 2009 16:30:52 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 22 May 2009 16:30:52 -0000 Received: (qmail 83162 invoked by uid 500); 22 May 2009 16:31:04 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 83109 invoked by uid 500); 22 May 2009 16:31:04 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 83098 invoked by uid 99); 22 May 2009 16:31:04 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 May 2009 16:31:04 +0000 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [193.252.22.151] (HELO smtp6.freeserve.com) (193.252.22.151) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 May 2009 16:30:55 +0000 Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf3524.me.freeserve.com (SMTP Server) with ESMTP id F0F7F1C0008A for ; Fri, 22 May 2009 18:30:32 +0200 (CEST) Received: from smtp.homeinbox.net (unknown [91.109.169.104]) by mwinf3524.me.freeserve.com (SMTP Server) with ESMTP id C78A91C00088 for ; Fri, 22 May 2009 18:30:31 +0200 (CEST) X-ME-UUID: 20090522163031817.C78A91C00088@mwinf3524.me.freeserve.com Received: from localhost (localhost [127.0.0.1]) by smtp.homeinbox.net (Postfix) with ESMTP id 5B9F71A4CD1 for ; Fri, 22 May 2009 17:30:42 +0100 (BST) X-Virus-Scanned: Debian amavisd-new at homeinbox.net Received: from smtp.homeinbox.net ([127.0.0.1]) by localhost (server01.dev.local [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2M+aGsR3wfmb for ; Fri, 22 May 2009 17:30:39 +0100 (BST) Received: from [192.168.0.9] (study03.dev.local [192.168.0.9]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.homeinbox.net (Postfix) with ESMTPSA id 276001A4CCE for ; Fri, 22 May 2009 17:30:39 +0100 (BST) Message-ID: <4A16D31B.102@apache.org> Date: Fri, 22 May 2009 17:30:19 +0100 From: Mark Thomas User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: svn commit: r776390 - /tomcat/tc6.0.x/trunk/STATUS.txt References: <20090519173521.E24E62388893@eris.apache.org> In-Reply-To: <20090519173521.E24E62388893@eris.apache.org> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org kkolinko@apache.org wrote: > Author: kkolinko > Date: Tue May 19 17:35:21 2009 > New Revision: 776390 > > URL: http://svn.apache.org/viewvc?rev=776390&view=rev > Log: > vote > > Modified: > tomcat/tc6.0.x/trunk/STATUS.txt > > Modified: tomcat/tc6.0.x/trunk/STATUS.txt > URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=776390&r1=776389&r2=776390&view=diff > ============================================================================== > --- tomcat/tc6.0.x/trunk/STATUS.txt (original) > +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue May 19 17:35:21 2009 > @@ -168,6 +168,18 @@ > Deregister all MBeans when the server is stopped > http://svn.apache.org/viewvc?rev=769979&view=rev > +1: markt, pero > + +1: kkolinko (ok, but one question: > + in MBeanUtils.java: > + > + @@ -1401,12 +1417,7 @@ > + static void destroyMBean(Context context) > + .. > + + String domain = context.getParent().getParent().getName(); > + if (domain == null) > + domain = mserver.getDefaultDomain(); > + > + Can domain be null here, Unlikely. We could probably ditch that test if we wanted to. > or one of those getParent().foo() calls result in an NPE ? No. Mark > + ) > -1: > > * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47080 > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org > For additional commands, e-mail: dev-help@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org