Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 18676 invoked from network); 22 May 2009 11:26:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 22 May 2009 11:26:49 -0000 Received: (qmail 58653 invoked by uid 500); 22 May 2009 11:27:01 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 58560 invoked by uid 500); 22 May 2009 11:27:01 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 58549 invoked by uid 99); 22 May 2009 11:27:01 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 May 2009 11:27:01 +0000 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [193.252.22.190] (HELO smtp6.freeserve.com) (193.252.22.190) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 May 2009 11:26:51 +0000 Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf3601.me.freeserve.com (SMTP Server) with ESMTP id 9F4AF7000082 for ; Fri, 22 May 2009 13:26:30 +0200 (CEST) Received: from smtp.homeinbox.net (unknown [91.109.169.104]) by mwinf3601.me.freeserve.com (SMTP Server) with ESMTP id 731C67000081 for ; Fri, 22 May 2009 13:26:30 +0200 (CEST) X-ME-UUID: 20090522112630471.731C67000081@mwinf3601.me.freeserve.com Received: from localhost (localhost [127.0.0.1]) by smtp.homeinbox.net (Postfix) with ESMTP id 0B5331A4CD1 for ; Fri, 22 May 2009 12:26:33 +0100 (BST) X-Virus-Scanned: Debian amavisd-new at homeinbox.net Received: from smtp.homeinbox.net ([127.0.0.1]) by localhost (server01.dev.local [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q1Bm8FyuuFic for ; Fri, 22 May 2009 12:26:29 +0100 (BST) Received: from [192.168.0.9] (study03.dev.local [192.168.0.9]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.homeinbox.net (Postfix) with ESMTPSA id C9FBF1A4CCE for ; Fri, 22 May 2009 12:26:29 +0100 (BST) Message-ID: <4A168BD2.1050102@apache.org> Date: Fri, 22 May 2009 12:26:10 +0100 From: Mark Thomas User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: svn commit: r775792 - /tomcat/tc6.0.x/trunk/STATUS.txt References: <20090518021505.BEE0023888D8@eris.apache.org> In-Reply-To: <20090518021505.BEE0023888D8@eris.apache.org> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org kkolinko@apache.org wrote: > Modified: tomcat/tc6.0.x/trunk/STATUS.txt > URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=775792&r1=775791&r2=775792&view=diff > ============================================================================== > --- tomcat/tc6.0.x/trunk/STATUS.txt (original) > +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon May 18 02:15:04 2009 > @@ -55,6 +55,23 @@ > http://svn.apache.org/viewvc?rev=746425&view=rev (to address Bill's concerns) > http://svn.apache.org/viewvc?rev=757335&view=rev (to remove the Catalina dep) > +1: markt, billbarker > + +1: kkolinko (good, but I have some concerns: > + r721286 : > + You have added an anonymous inner class to JspFactoryImpl. That class is > + preloaded by o.a.jasper.security.SecurityClassLoad. I wonder, whether the > + new inner class should also be preloaded. Do not have experience to prove > + it, though. I don't believe pre-loading is required in this case > + Plus, see issue #47214 in Bugzilla for my concerns on naming. ACK > + r721704 : > + o.k. > + (I have concerns about DefaultInstanceManager (see issue #47214), but > + that class does not exist in TC 6.0) ACK > + r746425: > + Implementation of ELResolverImpl.getDefaultResolver(): > + All those "(CompositeELResolver)" casts can be removed if you change > + type of the local variable. Fixed in trunk. I won't bother back-porting. Cheers, Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org