Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: neutral (nike.apache.org: local policy)
Message-ID: <4A09799D.3030900@apache.org>
Date: Tue, 12 May 2009 14:29:01 +0100
From: Mark Thomas <markt@apache.org>
User-Agent: Thunderbird 2.0.0.21 (Macintosh/20090302)
MIME-Version: 1.0
To: Tomcat Developers List <dev@tomcat.apache.org>
Subject: Re: svn commit: r772142 -
 /tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java
References: <20090506104904.18DC52388920@eris.apache.org>
	 <1241608411.3322.2.camel@localhost.localdomain>
	 <4A017FF0.5070408@apache.org>
 <427155180905092054hc69152fs8d4b36b1fa3bb423@mail.gmail.com>
In-Reply-To: <427155180905092054hc69152fs8d4b36b1fa3bb423@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Konstantin Kolinko wrote:
> 2009/5/6 Mark Thomas <markt@apache.org>:
>> Remy Maucherat wrote:
>>> On Wed, 2009-05-06 at 10:49 +0000, markt@apache.org wrote:
>>>>          // Acquire global JNDI resources if available
>>>> -        Server server = ServerFactory.getServer();
>>>> +        Server server =
>>>> +            ((Engine)context.getParent().getParent()).getService().getServer();
>>> Ouch, not pretty.
>> Any better ideas? I thought about pulling it out into a separate method but as
>> all of those parents should be non-null it seemed like overkill.
>>
> 
> See how setWrapper() is already implemented in ManagerServlet.
> You can remember Engine reference that it calculates there, like host
> reference that is already remembered.

Given I can get engine from host - I went with that. Slightly cleaner and I
don't think remembering the engine is worth it. If we were going to remember
anything extra, we should remember the server but I'm not sure it is worth it.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org