Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 22738 invoked from network); 7 Jul 2008 06:24:28 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 7 Jul 2008 06:24:28 -0000 Received: (qmail 68956 invoked by uid 500); 7 Jul 2008 06:24:27 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 68908 invoked by uid 500); 7 Jul 2008 06:24:27 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 68897 invoked by uid 99); 7 Jul 2008 06:24:27 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 06 Jul 2008 23:24:27 -0700 X-ASF-Spam-Status: No, hits=0.2 required=10.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [213.191.128.81] (HELO mxout2.iskon.hr) (213.191.128.81) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 07 Jul 2008 06:23:33 +0000 Received: (qmail 10830 invoked from network); 7 Jul 2008 08:23:53 +0200 X-Remote-IP: 213.191.142.122 Received: from unknown (HELO mx.iskon.hr) (213.191.142.122) by mxout2.iskon.hr with SMTP; 7 Jul 2008 08:23:53 +0200 Received: (qmail 15616 invoked from network); 7 Jul 2008 08:23:53 +0200 X-AVScan: ClamAV X-Remote-IP: 89.164.53.51 Received: from 53-51.dsl.iskon.hr (HELO ?192.168.0.10?) (89.164.53.51) by mx.iskon.hr with SMTP; 7 Jul 2008 08:23:53 +0200 Message-ID: <4871B675.8080401@apache.org> Date: Mon, 07 Jul 2008 08:23:49 +0200 From: Mladen Turk User-Agent: Thunderbird 1.5.0.12 (X11/20071129) MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: C code needs review References: <486FFB6E.1060208@apache.org> In-Reply-To: <486FFB6E.1060208@apache.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Mark Thomas wrote: > I've just attached a couple of patches to > https://issues.apache.org/bugzilla/show_bug.cgi?id=43327 > > One of the patches is a patch to native and since all I know just about > know enough C to be dangerous, I would be grateful if someone who > actually knows what they are doing when it comes to C could review it. > Patch makes sense, but at the first look it's not very well implemented. Think we could skip the conversion of compile time APR_* flags to our flag translation. Also, some socket implementations allows IPV4 bind on IPV6 socket, so it might be usable only when there is custom configuration that doesn't permit IPV4 bound IPV6 addresses. In standard case it might even break the things. I'll take a more deeper look at it this week. Cheers -- ^(TM) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org