Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 61843 invoked from network); 4 Feb 2008 11:01:40 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 4 Feb 2008 11:01:40 -0000 Received: (qmail 14419 invoked by uid 500); 4 Feb 2008 11:01:25 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 14370 invoked by uid 500); 4 Feb 2008 11:01:25 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 14359 invoked by uid 99); 4 Feb 2008 11:01:25 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Feb 2008 03:01:25 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of funkman@joedog.org designates 204.74.20.252 as permitted sender) Received: from [204.74.20.252] (HELO sid.armstrong.com) (204.74.20.252) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Feb 2008 11:01:10 +0000 Received: from [192.168.1.101] (c-71-225-53-88.hsd1.pa.comcast.net [71.225.53.88]) by sid.armstrong.com (8.13.6/8.12.8) with ESMTP id m14AoRfl018221 for ; Mon, 4 Feb 2008 05:50:28 -0500 Message-ID: <47A6F06D.9060205@joedog.org> Date: Mon, 04 Feb 2008 06:01:01 -0500 From: Tim Funk Organization: Human Being User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: svn commit: r618150 - /tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java References: <20080204021041.C9D631A9832@eris.apache.org> <47A67DA4.4090905@hanik.com> In-Reply-To: <47A67DA4.4090905@hanik.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org DefaultServlet is still using the old style debug. Its an initParameter. So I didn't change any of that functionality. It probably should be converted. -Tim Filip Hanik - Dev Lists wrote: > are we still using the debug attribute, or should it be > if log.isDebugEnabled log.debug... > > funkman@apache.org wrote: >> URL: http://svn.apache.org/viewvc?rev=618150&view=rev >> Log: >> http://issues.apache.org/bugzilla/show_bug.cgi?id=44337 >> Dir listing crashes if no readme-file present >> >> Catch NamingException on resource not found instead of checking for null >> Modified: >> tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java >> URL: >> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java?rev=618150&r1=618149&r2=618150&view=diff >> >> ============================================================================== >> >> --- tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java >> (original) >> +++ tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java >> Sun Feb 3 18:10:39 2008 >> @@ -1415,7 +1415,10 @@ >> return buffer.toString(); >> } >> } catch (NamingException e) { >> - throw new ServletException("Error opening readme >> resource", e); >> + if (debug > 10) >> + log("readme '" + readmeFile + "' not found", e); >> + >> + return null; --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org