Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 70674 invoked from network); 4 Feb 2008 02:52:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 4 Feb 2008 02:52:13 -0000 Received: (qmail 78479 invoked by uid 500); 4 Feb 2008 02:52:00 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 78262 invoked by uid 500); 4 Feb 2008 02:51:59 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 78251 invoked by uid 500); 4 Feb 2008 02:51:59 -0000 Delivered-To: apmail-jakarta-tomcat-dev@jakarta.apache.org Received: (qmail 77681 invoked by uid 99); 4 Feb 2008 02:51:57 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Feb 2008 18:51:57 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [72.22.94.67] (HELO virtual.halosg.com) (72.22.94.67) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Feb 2008 02:51:42 +0000 Received: (qmail 32444 invoked from network); 3 Feb 2008 20:43:14 -0600 Received: from 72-19-171-38.static.mesanetworks.net (HELO ?192.168.1.2?) (72.19.171.38) by halosg.com with SMTP; 3 Feb 2008 20:43:14 -0600 Message-ID: <47A67DA4.4090905@hanik.com> Date: Sun, 03 Feb 2008 19:51:16 -0700 From: Filip Hanik - Dev Lists User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: Tomcat Developers List CC: tomcat-dev@jakarta.apache.org Subject: Re: svn commit: r618150 - /tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java References: <20080204021041.C9D631A9832@eris.apache.org> In-Reply-To: <20080204021041.C9D631A9832@eris.apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org are we still using the debug attribute, or should it be if log.isDebugEnabled log.debug... Filip funkman@apache.org wrote: > Author: funkman > Date: Sun Feb 3 18:10:39 2008 > New Revision: 618150 > > URL: http://svn.apache.org/viewvc?rev=618150&view=rev > Log: > http://issues.apache.org/bugzilla/show_bug.cgi?id=44337 > Dir listing crashes if no readme-file present > > Catch NamingException on resource not found instead of checking for null > > > Modified: > tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java > > Modified: tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java > URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java?rev=618150&r1=618149&r2=618150&view=diff > ============================================================================== > --- tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java (original) > +++ tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java Sun Feb 3 18:10:39 2008 > @@ -1415,7 +1415,10 @@ > return buffer.toString(); > } > } catch (NamingException e) { > - throw new ServletException("Error opening readme resource", e); > + if (debug > 10) > + log("readme '" + readmeFile + "' not found", e); > + > + return null; > } > } > > @@ -1438,7 +1441,10 @@ > return is; > } > } catch (NamingException e) { > - throw new ServletException("Error opening XSLT resource", e); > + if (debug > 10) > + log("localXsltFile '" + localXsltFile + "' not found", e); > + > + return null; > } > } > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org > For additional commands, e-mail: dev-help@tomcat.apache.org > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org