Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@www.apache.org Received: (qmail 47993 invoked from network); 10 Jun 2005 04:23:51 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 10 Jun 2005 04:23:51 -0000 Received: (qmail 19876 invoked by uid 500); 10 Jun 2005 04:23:39 -0000 Delivered-To: apmail-jakarta-tomcat-dev-archive@jakarta.apache.org Received: (qmail 19819 invoked by uid 500); 10 Jun 2005 04:23:39 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Tomcat Developers List" Reply-To: "Tomcat Developers List" Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 19800 invoked by uid 99); 10 Jun 2005 04:23:39 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from whiskey.wilshire.com (HELO whiskey.wilshire.com) (209.0.86.69) by apache.org (qpsmtpd/0.28) with ESMTP; Thu, 09 Jun 2005 21:23:37 -0700 Received: from harpy.wilshire.com (harpy.wilshire.com [192.168.1.58]) by whiskey.wilshire.com (8.13.4/8.12.3/Debian-6.6) with ESMTP id j5A4NFPu032630 for ; Thu, 9 Jun 2005 21:23:15 -0700 Received: from oemcomputer (pool-71-107-252-60.lsanca.dsl-w.verizon.net [71.107.252.60]) (authenticated bits=0) by harpy.wilshire.com (8.12.10/8.12.3) with ESMTP id j5A4NFVF021966 for ; Thu, 9 Jun 2005 21:23:15 -0700 (PDT) Message-ID: <005701c56d74$3e2f2c40$3cfc6b47@oemcomputer> From: "Bill Barker" To: "Tomcat Developers List" References: <20050609161451.85792.qmail@minotaur.apache.org> Subject: Re: cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/coyote/ajp AjpAprProcessor.java Constants.java LocalStrings.properties AjpAprProtocol.java AjpMessage.java Date: Thu, 9 Jun 2005 21:24:01 -0700 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="Windows-1252"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.2180 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2180 X-Zantaz-Archived: whiskey Content-Disposition: inline X-Scanned-By: MIMEDefang 2.52 on 192.168.1.69 X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N ----- Original Message ----- From: To: Sent: Thursday, June 09, 2005 9:14 AM Subject: cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/coyote/ajp AjpAprProcessor.java Constants.java LocalStrings.properties AjpAprProtocol.java AjpMessage.java > remm 2005/06/09 09:14:51 > > Added: jk/java/org/apache/coyote/ajp AjpAprProcessor.java > Constants.java LocalStrings.properties > AjpAprProtocol.java AjpMessage.java > Log: > - Add my WIP AJP implementation using APR. Performance sucks right now, > and I think it has lots of bugs ;) > - It won't be compiled in or used for now. > Yeah, it has a few bugs ;). Would it mess you up if I were to fix some of the more glaring ones in the CVS copy? I'm thinking mostly of the double call to endRequest, and the failure to clean up the Request body parameters. The handling of remote/localHost/Port is also wrong, but relatively harmless. Also the lack of C2B handling on the Response headers is going to bite you someday, but for initial testing on a iso-8859-1 machine it's alright. This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. --------------------------------------------------------------------- To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org