Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Received-SPF: pass (hermes.apache.org: local policy)
From: "George Sexton" <gsexton@mhsoftware.com>
To: "'Tomcat Developers List'" <tomcat-dev@jakarta.apache.org>
Subject: RE: Code Submission - Wild Card Aliases
Date: Tue, 3 May 2005 09:33:32 -0600
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AcVP7QwsGDYkvPr+SSKAvlHbWo4EdAACFDvw
In-Reply-To: <427784ED.3080109@apache.org>
Message-Id: <20050503153352.52EE71EC96@mail.mhsoftware.com>

0.05% lower is hardly a sufficient reason to reject this.


George Sexton
MH Software, Inc.
http://www.mhsoftware.com/
Voice: 303 438 9585
 =20

> -----Original Message-----
> From: Remy Maucherat [mailto:remm@apache.org]=20
> Sent: Tuesday, May 03, 2005 8:04 AM
> To: Tomcat Developers List
> Subject: Re: Code Submission - Wild Card Aliases
>=20
> George Sexton wrote:
> > I have completed the coding in o.a.t.u.http.mapper.Mapper=20
> to implement
> > wild-card aliases.
> >=20
> > If a request for a host is made, and that host is not=20
> found, the code tests
> > the host and aliases list and looks for wild-cards.
> >=20
> > So, a host name of www.mydomain.com would match an alias of=20
> *.mydomain.com.
> > This additional level of testing is only done if the the=20
> presented host name
> > is not found in the standard host list. Once a host is=20
> found via wild-card,
> > it is added to the standard host list. Subsequent requests=20
> for that host
> > name will find it via the standard search mechanism.
> >=20
> > As part of the conversion, I re-worked the test harness=20
> code and expanded it
> > to be a lot more complete. The output of the new test=20
> harness with the
> > unmodified Mapper code matches identically the output of=20
> the modified
> > mapper. IOW, I'm 99% confident that the behavior of the=20
> Mapper matches the
> > old Mapper.
> >=20
> > The time differential between the two runs is around 500ms=20
> over 1 million
> > iterations. I.E. the original code runs in 8000 ms for 1=20
> million iterations
> > of the testing code, while the new code takes 8500ms. The=20
> new code adds
> > approximately 0.05 % to the time for a lookup.
> >=20
> > I am running the modified mapper code with 5.5.9 on an=20
> installation that has
> > 40 hosts configured and it seems to be working correctly.
> >=20
> > I'd really appreciate it if a committer would get this=20
> added to the source
> > tree.
> >=20
> > The complete modified Mapper.java file can be downloaded from:
> >=20
> > http://www.mhsoftware.com/~gsexton/Mapper.java
> >=20
> > If a decision is made to reject this patch, I'd appreciate=20
> knowing why. If
> > there's something wrong from a coding or style perspective,=20
> I'd be happy to
> > fix things.
>=20
> -1 for lower performance and questionable use case.
> (I didn't get the patch, but I don't really wish to)
>=20
> R=E9my
>=20
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>=20
>=20


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org