Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Message-ID: <002f01c41b76$9a707a50$ec66a8c0@bbarkerxp>
From: "Bill Barker" <wbarker@wilshire.com>
To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
References: <20040406005507.66217.qmail@minotaur.apache.org>
Subject: Re: cvs commit:
 jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5
 CoyoteAdapter.java CoyoteOutputStream.java CoyoteReader.java
 CoyoteRequest.java CoyoteWriter.java
Date: Mon, 5 Apr 2004 18:29:28 -0700
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----------=_1081214917-11330-366"

------------=_1081214917-11330-366
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


----- Original Message -----
From: <jfarcand@apache.org>
To: <jakarta-tomcat-catalina-cvs@apache.org>
Sent: Monday, April 05, 2004 5:55 PM
Subject: cvs commit:
jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5
CoyoteAdapter.java CoyoteOutputStream.java CoyoteReader.java
CoyoteRequest.java CoyoteWriter.java


> jfarcand    2004/04/05 17:55:07
>
>   Modified:    catalina/src/share/org/apache/coyote/tomcat5
>                         CoyoteAdapter.java CoyoteOutputStream.java
>                         CoyoteReader.java CoyoteRequest.java
>                         CoyoteWriter.java
>   Log:
>   Add public method consistently. Currently some methods were private,
some final
>   and some public.

I'm -0 on this.  The classes modified are all internal to the Tomcat 5.x
CoyoteConnector, so there is no good reason to make them public.

>
>   Making such classes public allowed re-utilization of those classes as a
base for new connector( ex: NSAPI)
>

The way that Coyote is designed, this should always be unnecessary.  The way
to build a new connector is to define a new ProtocolHandler that deals with
the transport.


------------=_1081214917-11330-366
Content-Type: text/plain; name="disclaimer.txt"
Content-Disposition: inline; filename="disclaimer.txt"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-Mailer: MIME-tools 5.411 (Entity 5.404)


This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail.


------------=_1081214917-11330-366
Content-Type: text/plain; charset=us-ascii

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
------------=_1081214917-11330-366--