Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@www.apache.org Received: (qmail 99433 invoked from network); 23 Mar 2004 20:48:24 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 23 Mar 2004 20:48:24 -0000 Received: (qmail 1533 invoked by uid 500); 23 Mar 2004 20:47:58 -0000 Delivered-To: apmail-jakarta-tomcat-dev-archive@jakarta.apache.org Received: (qmail 1484 invoked by uid 500); 23 Mar 2004 20:47:58 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Tomcat Developers List" Reply-To: "Tomcat Developers List" Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 1438 invoked from network); 23 Mar 2004 20:47:58 -0000 Received: from unknown (HELO exchange.sun.com) (192.18.33.10) by daedalus.apache.org with SMTP; 23 Mar 2004 20:47:58 -0000 Received: (qmail 26607 invoked by uid 50); 23 Mar 2004 20:48:38 -0000 Date: 23 Mar 2004 20:48:38 -0000 Message-ID: <20040323204838.26606.qmail@nagoya.betaversion.org> From: bugzilla@apache.org To: tomcat-dev@jakarta.apache.org Cc: Subject: DO NOT REPLY [Bug 16830] - Jasper do not reset BodyContent for tags with BodySupport and empty content X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=16830 Jasper do not reset BodyContent for tags with BodySupport and empty content ------- Additional Comments From kin-man.chung@sun.com 2004-03-23 20:48 ------- OK, let's quote some specs first. :-) JSP 1.2 spec, p 177 (JSP.10.2 BodyTag) Under "Properties": "The setter method (setBodyContent) will only be invoked if doStartTag( ) returns EVAL_BODY_BUFFERED." So it is obvious that if doStartTag returns SKIP_BODY, setBodyContent will not be called. But that was what I said before. JSP 2.0 spec further tightens the condition (JSP.13.22 p 2-67): "The setter method (setBodyContent) will only be invoked if doStartTag() returns EVAL_BODY_BUFFERED and the corresponding action element does not have an empty body." so setBodyContent will not be called if the body is empty also. So technically, the patch suggested by Vit Timchishin actually violates the spec, because setBodyContent will be called in places where it shouldn't. I won't be surprised if the patch breaks some TCK tests. But does it make sense, you all ask? Personally, I think it should be allowed to reset the bodyContent to null in such cases, and it is an oversight in the spec to not consider the interaction with tag pooling in this corner case. I'll check with the JSP spec leads on this. Unless I can find a fix that does not break the spec, this bug will remain INVALID. --------------------------------------------------------------------- To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org