Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@apache.org Received: (qmail 58288 invoked from network); 1 May 2003 17:23:22 -0000 Received: from exchange.sun.com (192.18.33.10) by daedalus.apache.org with SMTP; 1 May 2003 17:23:22 -0000 Received: (qmail 5463 invoked by uid 97); 1 May 2003 17:25:24 -0000 Delivered-To: qmlist-jakarta-archive-tomcat-dev@nagoya.betaversion.org Received: (qmail 5456 invoked from network); 1 May 2003 17:25:24 -0000 Received: from daedalus.apache.org (HELO apache.org) (208.185.179.12) by nagoya.betaversion.org with SMTP; 1 May 2003 17:25:24 -0000 Received: (qmail 57432 invoked by uid 500); 1 May 2003 17:23:13 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Tomcat Developers List" Reply-To: "Tomcat Developers List" Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 57414 invoked from network); 1 May 2003 17:23:13 -0000 Received: from exchange.sun.com (192.18.33.10) by daedalus.apache.org with SMTP; 1 May 2003 17:23:13 -0000 Received: (qmail 5445 invoked by uid 50); 1 May 2003 17:25:15 -0000 Date: 1 May 2003 17:25:15 -0000 Message-ID: <20030501172515.5444.qmail@nagoya.betaversion.org> From: bugzilla@apache.org To: tomcat-dev@jakarta.apache.org Cc: Subject: DO NOT REPLY [Bug 19521] New: - RequestDumperValve gets in the way of request.setCharacterEncoding X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19521 RequestDumperValve gets in the way of request.setCharacterEncoding Summary: RequestDumperValve gets in the way of request.setCharacterEncoding Product: Tomcat 4 Version: 4.1.18 Platform: PC OS/Version: Windows NT/2K Status: NEW Severity: Normal Priority: Other Component: Catalina:Modules AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: dclarke@rim.net In order to set the character encoding for a particular request, Request.setCharacterEncoding must be called before any calls to the other Request methods are made. When RequestDumperValve is active, it intercepts requests before they get to the servlet. When it calls methods on the request object to gather up information for logging, it has the side affect of setting the character encoding to the platform default. This may be considered as designed behavior, however it is not obvious that this is what is happening. For developers writing Internationalized code, this can cause a lot of cycles to be wasted. Some possible alternatives (probably more than just these): * Have RequestDumperValve wait until after the Servlet has been invoked before gathering information for logging. * Have Request.setCharacterEncoding throw an exception or log some highly visible information when it detects that the new encoding will have no affect. This log information should say something about RequestDumperValve so the user is pointed in the right direction for a fix. * other better ideas??? --------------------------------------------------------------------- To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org