Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@apache.org Received: (qmail 54025 invoked from network); 17 Aug 2002 01:37:04 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 17 Aug 2002 01:37:04 -0000 Received: (qmail 12318 invoked by uid 97); 17 Aug 2002 01:37:31 -0000 Delivered-To: qmlist-jakarta-archive-tomcat-dev@jakarta.apache.org Received: (qmail 12258 invoked by uid 97); 17 Aug 2002 01:37:31 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Tomcat Developers List" Reply-To: "Tomcat Developers List" Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 12246 invoked by uid 98); 17 Aug 2002 01:37:30 -0000 X-Antivirus: nagoya (v4198 created Apr 24 2002) Content-Type: text/plain; charset="us-ascii" From: Steve Downey To: tomcat-dev@jakarta.apache.org Subject: Watchdog aggregation of headers may be incorrect Date: Fri, 16 Aug 2002 21:35:27 -0400 User-Agent: KMail/1.4.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-Id: <200208162135.27666.steve.downey@netfolio.com> X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Watchdog now merges headers, by design. ie (from the checking message) Modified logic to send duplicate headers as one aggregated header vs. two= =20 headers: header1: val1 header1: val2 -will now be- header1: val1, val2 Due to this, it looks like a couple of tests are failing. GetHeadersTest = and=20 HttpServletRequestWrapperGetHeadersTest.=20 GetHeadersTest looks for two Accept-Language headers, en-us and ga-us. It= does=20 work if they are sent as Accept-Language:en-us Accept-Language:ga-us But, being sent as: Accept-Language:en-us, ga-us it is presented to the servlet as ONE header, with the value "en-us, ga-u= s" However, I'm not sure that it shouldn't be. Parsing a multivalued header = is=20 not only diffcult, it seems to depend on which header is being parsed.=20 Certainly full interpretation is very dependent on the header, e.g. Accept-Language: da, en-gb;q=3D0.8, en;q=3D0.7 Date: Wed, 15 Nov 1995 06:25:24 GMT The first has three values, the second has one. Interpretation depends on= the=20 name of the header. I don't believe the Request.getHeaders() mechanism sh= ould=20 try and interpret the values after the :. -- To unsubscribe, e-mail: For additional commands, e-mail: