Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@apache.org Received: (qmail 10243 invoked from network); 30 Oct 2001 17:31:35 -0000 Received: from unknown (HELO osaka.betaversion.org) (192.18.49.133) by daedalus.apache.org with SMTP; 30 Oct 2001 17:31:35 -0000 Received: (qmail 24130 invoked from network); 30 Oct 2001 17:33:58 -0000 Received: from nagoya.betaversion.org (192.18.49.131) by osaka.betaversion.org with SMTP; 30 Oct 2001 17:33:58 -0000 Received: (qmail 22077 invoked by uid 97); 30 Oct 2001 17:29:54 -0000 Delivered-To: qmlist-jakarta-tomcat-dev-archive@jakarta.apache.org Received: (qmail 22017 invoked by uid 97); 30 Oct 2001 17:29:52 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Tomcat Developers List" Reply-To: "Tomcat Developers List" Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 21986 invoked from network); 30 Oct 2001 17:29:50 -0000 Sender: jfclere@vtxrm2.bcn.fsc.net Message-ID: <3BDEEF4D.4F82D451@fujitsu-siemens.com> Date: Tue, 30 Oct 2001 19:19:57 +0100 From: jean-frederic clere Reply-To: jfrederic.clere@fujitsu-siemens.com X-Mailer: Mozilla 4.77 [en] (X11; U; Linux 2.4.7 i686) X-Accept-Language: en, fr, de MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/ajp/tomcat4Ajp13Connector.java References: <20011030085949.N95388-100000@localhost> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N "Craig R. McClanahan" wrote: > > On Tue, 30 Oct 2001, Remy Maucherat wrote: > > > Date: Tue, 30 Oct 2001 09:04:25 -0800 > > From: Remy Maucherat > > Reply-To: Tomcat Developers List > > To: Tomcat Developers List > > Subject: Re: cvs commit: > > jakarta-tomcat-connectors/jk/java/org/apache/ajp/tomcat4 > > Ajp13Connector.java > > > > > jfclere 01/10/30 05:20:46 > > > > > > Modified: jk/java/org/apache/ajp/tomcat4 Ajp13Connector.java > > > Log: > > > Use org.apache.catalina.ServerSocketFactory instead > > > org.apache.catalina.net.ServerSocketFactory that has been deprecated. > > > > It's not a good idea to do that at this time, IMO, as jk won't build against > > the 4.0 branch (I suppose this only proves we should have created a branch > > in j-t-c too). > > > > In fact, the reason I left org.apache.catalina.net.ServerSocketFactory > there was so that you *could* use it and compile JK and WEBAPP against > either branch. The deprecation just warns HEAD branch developers to > stay away. And my bad is that I fixed both... The error I got: +++ build-main: [javac] Compiling 1 source file to /home/jakarta/jakarta-tomcat-connectors/jk/build/WEB-INF/classes [javac] /home/jakarta/jakarta-tomcat-connectors/jk/java/org/apache/ajp/tomcat4/Ajp13Connector.java:88: warning: org.apache.catalina.net.ServerSocketFactory in org.apache.catalina.net has been deprecated [javac] import org.apache.catalina.net.ServerSocketFactory; [javac] ^ [javac] /home/jakarta/jakarta-tomcat-connectors/jk/java/org/apache/ajp/tomcat4/Ajp13Connector.java:153: warning: org.apache.catalina.net.ServerSocketFactory in org.apache.catalina.net has been deprecated [javac] private ServerSocketFactory factory = null; [javac] ^ [javac] /home/jakarta/jakarta-tomcat-connectors/jk/java/org/apache/ajp/tomcat4/Ajp13Connector.java:470: warning: org.apache.catalina.net.ServerSocketFactory in org.apache.catalina.net has been deprecated [javac] public ServerSocketFactory getFactory() { [javac] ^ [javac] /home/jakarta/jakarta-tomcat-connectors/jk/java/org/apache/ajp/tomcat4/Ajp13Connector.java:487: warning: org.apache.catalina.net.ServerSocketFactory in org.apache.catalina.net has been deprecated [javac] public void setFactory(ServerSocketFactory factory) { [javac] ^ [javac] /home/jakarta/jakarta-tomcat-connectors/jk/java/org/apache/ajp/tomcat4/Ajp13Connector.java:100: org.apache.ajp.tomcat4.Ajp13Connector should be declared abstract; it does not define setFactory(org.apache.catalina.ServerSocketFactory) in org.apache.ajp.tomcat4.Ajp13Connector [javac] public final class Ajp13Connector [javac] ^ [javac] /home/jakarta/jakarta-tomcat-connectors/jk/java/org/apache/ajp/tomcat4/Ajp13Connector.java:474: incompatible types [javac] found : org.apache.catalina.net.DefaultServerSocketFactory [javac] required: org.apache.catalina.net.ServerSocketFactory [javac] this.factory = new DefaultServerSocketFactory(); [javac] ^ [javac] /home/jakarta/jakarta-tomcat-connectors/jk/java/org/apache/ajp/tomcat4/Ajp13Connector.java:487: warning: org.apache.catalina.net.ServerSocketFactory in org.apache.catalina.net has been deprecated [javac] public void setFactory(ServerSocketFactory factory) { [javac] ^ [javac] /home/jakarta/jakarta-tomcat-connectors/jk/java/org/apache/ajp/tomcat4/Ajp13Connector.java:737: warning: org.apache.catalina.net.ServerSocketFactory in org.apache.catalina.net has been deprecated [javac] ServerSocketFactory factory = getFactory(); [javac] ^ [javac] 2 errors [javac] 6 warnings BUILD FAILED +++ So undoing the 2 patches is not enough. > > > Remy > > > > Craig > > -- > To unsubscribe, e-mail: > For additional commands, e-mail: -- To unsubscribe, e-mail: For additional commands, e-mail: