tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jean-frederic clere <jfrederic.cl...@fujitsu-siemens.com>
Subject Re: cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/ajp/tomcat4Ajp13Connector.java
Date Tue, 30 Oct 2001 18:19:57 GMT
"Craig R. McClanahan" wrote:
> 
> On Tue, 30 Oct 2001, Remy Maucherat wrote:
> 
> > Date: Tue, 30 Oct 2001 09:04:25 -0800
> > From: Remy Maucherat <rmaucher1@home.com>
> > Reply-To: Tomcat Developers List <tomcat-dev@jakarta.apache.org>
> > To: Tomcat Developers List <tomcat-dev@jakarta.apache.org>
> > Subject: Re: cvs commit:
> >     jakarta-tomcat-connectors/jk/java/org/apache/ajp/tomcat4
> >     Ajp13Connector.java
> >
> > > jfclere     01/10/30 05:20:46
> > >
> > >   Modified:    jk/java/org/apache/ajp/tomcat4 Ajp13Connector.java
> > >   Log:
> > >   Use org.apache.catalina.ServerSocketFactory instead
> > >   org.apache.catalina.net.ServerSocketFactory that has been deprecated.
> >
> > It's not a good idea to do that at this time, IMO, as jk won't build against
> > the 4.0 branch (I suppose this only proves we should have created a branch
> > in j-t-c too).
> >
> 
> In fact, the reason I left org.apache.catalina.net.ServerSocketFactory
> there was so that you *could* use it and compile JK and WEBAPP against
> either branch.  The deprecation just warns HEAD branch developers to
> stay away.

And my bad is that I fixed both...
The error I got:
+++
build-main:
    [javac] Compiling 1 source file to
/home/jakarta/jakarta-tomcat-connectors/jk/build/WEB-INF/classes
    [javac]
/home/jakarta/jakarta-tomcat-connectors/jk/java/org/apache/ajp/tomcat4/Ajp13Connector.java:88:
warning: org.apache.catalina.net.ServerSocketFactory in org.apache.catalina.net
has been deprecated
    [javac] import org.apache.catalina.net.ServerSocketFactory;
    [javac]                                ^
    [javac]
/home/jakarta/jakarta-tomcat-connectors/jk/java/org/apache/ajp/tomcat4/Ajp13Connector.java:153:
warning: org.apache.catalina.net.ServerSocketFactory in org.apache.catalina.net
has been deprecated
    [javac]     private ServerSocketFactory factory = null;
    [javac]             ^
    [javac]
/home/jakarta/jakarta-tomcat-connectors/jk/java/org/apache/ajp/tomcat4/Ajp13Connector.java:470:
warning: org.apache.catalina.net.ServerSocketFactory in org.apache.catalina.net
has been deprecated
    [javac]     public ServerSocketFactory getFactory() {
    [javac]            ^
    [javac]
/home/jakarta/jakarta-tomcat-connectors/jk/java/org/apache/ajp/tomcat4/Ajp13Connector.java:487:
warning: org.apache.catalina.net.ServerSocketFactory in org.apache.catalina.net
has been deprecated
    [javac]     public void setFactory(ServerSocketFactory factory) {
    [javac]                            ^
    [javac]
/home/jakarta/jakarta-tomcat-connectors/jk/java/org/apache/ajp/tomcat4/Ajp13Connector.java:100:
org.apache.ajp.tomcat4.Ajp13Connector should be declared abstract; it does not
define setFactory(org.apache.catalina.ServerSocketFactory) in
org.apache.ajp.tomcat4.Ajp13Connector
    [javac] public final class Ajp13Connector
    [javac]              ^
    [javac]
/home/jakarta/jakarta-tomcat-connectors/jk/java/org/apache/ajp/tomcat4/Ajp13Connector.java:474:
incompatible types
    [javac] found   : org.apache.catalina.net.DefaultServerSocketFactory
    [javac] required: org.apache.catalina.net.ServerSocketFactory
    [javac]                 this.factory = new DefaultServerSocketFactory();
    [javac]                                ^
    [javac]
/home/jakarta/jakarta-tomcat-connectors/jk/java/org/apache/ajp/tomcat4/Ajp13Connector.java:487:
warning: org.apache.catalina.net.ServerSocketFactory in org.apache.catalina.net
has been deprecated
    [javac]     public void setFactory(ServerSocketFactory factory) {
    [javac]                            ^
    [javac]
/home/jakarta/jakarta-tomcat-connectors/jk/java/org/apache/ajp/tomcat4/Ajp13Connector.java:737:
warning: org.apache.catalina.net.ServerSocketFactory in org.apache.catalina.net
has been deprecated
    [javac]         ServerSocketFactory factory = getFactory();
    [javac]         ^
    [javac] 2 errors
    [javac] 6 warnings
 
BUILD FAILED
+++
So undoing the 2 patches is not enough.
> 
> > Remy
> >
> 
> Craig
> 
> --
> To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>

--
To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>


Mime
View raw message