tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Anderson" <>
Subject Patches for native plugins (3.2.1)
Date Thu, 07 Dec 2000 17:02:58 GMT
Here are a couple of patches for the native plugins on NetWare.  The first one fixes a problem
when submitting dating from a form with a POST request.  I'd been testing with the latest
internal Enterprise Server headers and someone found out that NetWare 5.1 doesn't have some
the assumed functionality (netbuf_getbytes).

cvs -z9 -q diff jk_nsapi_plugin.c (in directory D:\Jakarta\jakarta-tomcat\src\native\netscape\)
Index: jk_nsapi_plugin.c
RCS file: /home/cvspublic/jakarta-tomcat/src/native/netscape/Attic/jk_nsapi_plugin.c,v
retrieving revision 1.3
diff -r1.3 jk_nsapi_plugin.c
< #ifdef netbuf_getbytes
> /* Until we get a service pack for NW5.1 and earlier that has the latest */
> /* Enterprise Server, we have to go through the else version of this code*/
> #if defined(netbuf_getbytes) && !defined(NETWARE)

This patch is necessary because when the plugin is shutting down, the thread that the code
is being run on will likely only have a 16k stack.  Since jk_log created an 8k buffer on the
stack, there were some cases that we ran off the stack.

cvs -z9 -q diff jk_util.c (in directory D:\Jakarta\jakarta-tomcat\src\native\jk\)
Index: jk_util.c
RCS file: /home/cvspublic/jakarta-tomcat/src/native/jk/Attic/jk_util.c,v
retrieving revision
diff -r1.6.2.2 jk_util.c
> #ifdef NETWARE
> /* On NetWare, this can get called on a thread that has a limited stack so */
> /* we will allocate and free the temporary buffer in this function         */
>         char *buf;
> #else
> #endif
>         buf = (char *) malloc(HUGE_BUFFER_SIZE);
>         if (NULL == buf)
>            return -1;
> #ifdef NETWARE
>         free(buf);
> #endif

Both of these fixes only affect NetWare so if these could be checked in, I would appreciate
it.  I will be happy to provide associated binaries once these files are checked in.

Mike Anderson
Senior Software Engineer
Platform Services Group
Novell, Inc., the leading provider of Net services software

View raw message