From commits-return-40481-archive-asf-public=cust-asf.ponee.io@tinkerpop.apache.org Wed Sep 2 14:30:32 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id C74F618065D for ; Wed, 2 Sep 2020 16:30:32 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 00A2D12179B for ; Wed, 2 Sep 2020 14:30:32 +0000 (UTC) Received: (qmail 25040 invoked by uid 500); 2 Sep 2020 14:30:31 -0000 Mailing-List: contact commits-help@tinkerpop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tinkerpop.apache.org Delivered-To: mailing list commits@tinkerpop.apache.org Received: (qmail 25031 invoked by uid 99); 2 Sep 2020 14:30:31 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Sep 2020 14:30:31 +0000 From: =?utf-8?q?GitBox?= To: commits@tinkerpop.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Btinkerpop=5D_spmallette_opened_a_new_pull_request_?= =?utf-8?q?=231322=3A_TINKERPOP-2413_withEmbedded=28=29?= Message-ID: Date: Wed, 02 Sep 2020 14:30:31 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit spmallette opened a new pull request #1322: URL: https://github.com/apache/tinkerpop/pull/1322 https://issues.apache.org/jira/browse/TINKERPOP-2413 Deprecated `withGraph()` on `AnonymousTraversalSource` in favor of `withEmbedded()`. Didn't really alter tests so as to keep testing running through the old deprecated method which basically just proxies to `withEmbedded()`. GLVs didn't need much change since there really is no "embedded" option there. For python and .NET, i changed nothing since there is no embedded version. For javascript I explicitly deprecated `withGraph()` and fixed up jsdoc a bit. Modified documentation to better promote `withEmbedded()` - not sure why we didn't do that for `withGraph()` long ago (perhaps the idea was to wait for 3.5.0, but in a way I'm sorta glad we didn't as we've now deprecated. All tests pass with `docker/build.sh -t -n -i` VOTE +1 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org