From commits-return-40516-archive-asf-public=cust-asf.ponee.io@tinkerpop.apache.org Thu Sep 3 22:02:07 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id E79FF180636 for ; Fri, 4 Sep 2020 00:02:06 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 2108F121B35 for ; Thu, 3 Sep 2020 22:02:06 +0000 (UTC) Received: (qmail 75656 invoked by uid 500); 3 Sep 2020 22:02:06 -0000 Mailing-List: contact commits-help@tinkerpop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tinkerpop.apache.org Delivered-To: mailing list commits@tinkerpop.apache.org Received: (qmail 75647 invoked by uid 99); 3 Sep 2020 22:02:05 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Sep 2020 22:02:05 +0000 From: =?utf-8?q?GitBox?= To: commits@tinkerpop.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Btinkerpop=5D_divijvaidya_commented_on_a_change_in_?= =?utf-8?q?pull_request_=231312=3A_Make_TinkerVertex_non-final?= Message-ID: <159917052576.32230.14623890345498348680.asfpy@gitbox.apache.org> Date: Thu, 03 Sep 2020 22:02:05 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: divijvaidya commented on a change in pull request #1312: URL: https://github.com/apache/tinkerpop/pull/1312#discussion_r483277388 ########## File path: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversal.java ########## @@ -350,6 +351,10 @@ public void setGraph(final Graph graph) { this.graph = graph; } + public void setLocked(boolean locked) { Review comment: It's a separate conversation. I will soon raise a PR for that. I think that the way in which we apply strategies (first to all steps and then to each children one at a time), could be improved to apply all strategies at the same time to the entire traversal and sub-traversal. I will remove this change from this PR, pending further discussion on a new PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org