From commits-return-40515-archive-asf-public=cust-asf.ponee.io@tinkerpop.apache.org Thu Sep 3 22:00:35 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 9DE4C180636 for ; Fri, 4 Sep 2020 00:00:35 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id 091FE62A1E for ; Thu, 3 Sep 2020 22:00:34 +0000 (UTC) Received: (qmail 74585 invoked by uid 500); 3 Sep 2020 22:00:34 -0000 Mailing-List: contact commits-help@tinkerpop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tinkerpop.apache.org Delivered-To: mailing list commits@tinkerpop.apache.org Received: (qmail 74576 invoked by uid 99); 3 Sep 2020 22:00:34 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Sep 2020 22:00:34 +0000 From: =?utf-8?q?GitBox?= To: commits@tinkerpop.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Btinkerpop=5D_divijvaidya_commented_on_a_change_in_?= =?utf-8?q?pull_request_=231312=3A_Make_TinkerVertex_non-final?= Message-ID: <159917043415.32230.5608590340330709789.asfpy@gitbox.apache.org> Date: Thu, 03 Sep 2020 22:00:34 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: divijvaidya commented on a change in pull request #1312: URL: https://github.com/apache/tinkerpop/pull/1312#discussion_r483276801 ########## File path: tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerVertex.java ########## @@ -40,7 +40,7 @@ /** * @author Marko A. Rodriguez (http://markorodriguez.com) */ -public final class TinkerVertex extends TinkerElement implements Vertex { Review comment: It could be extended by vendors to create a custom testing suite OR it could be used by vendors to build a TinkerGraph++ offering. IMO, we should probably relax the final requirement on classes unless it is necessary or has some specific purpose. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org