From commits-return-40514-archive-asf-public=cust-asf.ponee.io@tinkerpop.apache.org Thu Sep 3 21:46:21 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id CBAB3180636 for ; Thu, 3 Sep 2020 23:46:21 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 09C89121CFA for ; Thu, 3 Sep 2020 21:46:21 +0000 (UTC) Received: (qmail 60653 invoked by uid 500); 3 Sep 2020 21:46:20 -0000 Mailing-List: contact commits-help@tinkerpop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tinkerpop.apache.org Delivered-To: mailing list commits@tinkerpop.apache.org Received: (qmail 60644 invoked by uid 99); 3 Sep 2020 21:46:20 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Sep 2020 21:46:20 +0000 From: =?utf-8?q?GitBox?= To: commits@tinkerpop.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Btinkerpop=5D_divijvaidya_commented_on_a_change_in_?= =?utf-8?q?pull_request_=231312=3A_Make_TinkerVertex_non-final?= Message-ID: <159916958080.32230.8627231763931486039.asfpy@gitbox.apache.org> Date: Thu, 03 Sep 2020 21:46:20 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: divijvaidya commented on a change in pull request #1312: URL: https://github.com/apache/tinkerpop/pull/1312#discussion_r483271227 ########## File path: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/GroupCountStep.java ########## @@ -41,7 +41,7 @@ /** * @author Marko A. Rodriguez (http://markorodriguez.com) */ -public final class GroupCountStep extends ReducingBarrierStep> implements TraversalParent, ByModulating { +public class GroupCountStep extends ReducingBarrierStep> implements TraversalParent, ByModulating { Review comment: Let me change the scope of this PR to only change visibility of certain members. We can pick up removing the final keyword after a discussion in email list. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org