From commits-return-40453-archive-asf-public=cust-asf.ponee.io@tinkerpop.apache.org Tue Sep 1 00:33:18 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id CA2EA18063F for ; Tue, 1 Sep 2020 02:33:18 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 06904123C90 for ; Tue, 1 Sep 2020 00:33:18 +0000 (UTC) Received: (qmail 41720 invoked by uid 500); 1 Sep 2020 00:33:17 -0000 Mailing-List: contact commits-help@tinkerpop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tinkerpop.apache.org Delivered-To: mailing list commits@tinkerpop.apache.org Received: (qmail 41707 invoked by uid 99); 1 Sep 2020 00:33:17 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2020 00:33:17 +0000 From: =?utf-8?q?GitBox?= To: commits@tinkerpop.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Btinkerpop=5D_spmallette_commented_on_pull_request_?= =?utf-8?q?=231318=3A_TINKERPOP-2410_Release_server_threads_waiting_on_conne?= =?utf-8?q?ction_if_the_connection_is_dead=2E_?= Message-ID: <159892039766.32230.17409756512929705320.asfpy@gitbox.apache.org> Date: Tue, 01 Sep 2020 00:33:17 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: spmallette commented on pull request #1318: URL: https://github.com/apache/tinkerpop/pull/1318#issuecomment-684120489 I see you brought in the fix from 3.4-dev and the test failure is cleaned up. I'm good with this change - builds with: `mvn clean install -pl gremlin-server,gremlin-console -DskipIntegrationTests=false -DincludeNeo4j` VOTE +1 (i assume you won't bring in that merge commit at d632f2a to the release branches and will squash the "changelog" commit) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org