tinkerpop-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [tinkerpop] rdtr opened a new pull request #1325: [TINKERPOP-2416] MultiIterator implement AutoCloseable and close hold…
Date Mon, 07 Sep 2020 05:25:19 GMT

rdtr opened a new pull request #1325:
URL: https://github.com/apache/tinkerpop/pull/1325


   As described in the [JIRA](https://issues.apache.org/jira/browse/TINKERPOP-2416), currently
`MultiIterator` does not implement `AutoCloseable`. This potentially introduces resource leak
when we have multiple iterators that implement `AutoCloseable` and combine them using `IteratorUtils#concat`.
The caller may expect all iterators to be closed automatically by calling `CloseableIterator#closeIterator`
but right now `MultiIterator` doesn't implement AutoCloseable so even the underlying iterators
are auto-closeable, they are never be closed.
   
   This simple PR just adds AutoCloseable implementation to MultiIterator, close all inner
iterators if they implement AutoCloseable.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message