tinkerpop-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [tinkerpop] spmallette opened a new pull request #1322: TINKERPOP-2413 withEmbedded()
Date Wed, 02 Sep 2020 14:30:31 GMT

spmallette opened a new pull request #1322:
URL: https://github.com/apache/tinkerpop/pull/1322


   https://issues.apache.org/jira/browse/TINKERPOP-2413
   
   Deprecated `withGraph()` on `AnonymousTraversalSource` in favor of `withEmbedded()`. Didn't
really alter tests so as to keep testing running through the old deprecated method which basically
just proxies to `withEmbedded()`. GLVs didn't need much change since there really is no "embedded"
option there. For python and .NET, i changed nothing since there is no embedded version. For
javascript I explicitly deprecated `withGraph()` and fixed up jsdoc a bit. Modified documentation
to better promote `withEmbedded()` - not sure why we didn't do that for `withGraph()` long
ago (perhaps the idea was to wait for 3.5.0, but in a way I'm sorta glad we didn't as we've
now deprecated.
   
   All tests pass with `docker/build.sh -t -n -i`
   
   VOTE +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message