tinkerpop-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [tinkerpop] QwentB commented on pull request #1308: TINKERPOP-2389 WIP: Authorization support in TinkerPop
Date Mon, 07 Sep 2020 08:16:34 GMT

QwentB commented on pull request #1308:
URL: https://github.com/apache/tinkerpop/pull/1308#issuecomment-688149654


   @vtslab functionnaly this is what I had in mind.
   I'm not sure to understand your point about the WS connection closing. If the WebSocket
connection is closed not further calls would be made on the Authenticator/Authorizer so their
state and the presence of the properties does not really matter. 
   This being said, we should make sure they will all be cleanly garbage collected and it
might requires some 'dispose' action. I'm not very familiar with Netty but there should be
a way to be notified when the Channel is being closed.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message