tinkerpop-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [tinkerpop] divijvaidya commented on a change in pull request #1312: Make TinkerVertex non-final
Date Thu, 03 Sep 2020 22:00:34 GMT

divijvaidya commented on a change in pull request #1312:
URL: https://github.com/apache/tinkerpop/pull/1312#discussion_r483276801



##########
File path: tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerVertex.java
##########
@@ -40,7 +40,7 @@
 /**
  * @author Marko A. Rodriguez (http://markorodriguez.com)
  */
-public final class TinkerVertex extends TinkerElement implements Vertex {

Review comment:
       It could be extended by vendors to create a custom testing suite OR it could be used
by vendors to build a TinkerGraph++ offering. IMO, we should probably relax the final requirement
on classes unless it is necessary or has some specific purpose.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message