From notifications-return-1044-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Thu Feb 18 16:45:21 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 4EB11180686 for ; Thu, 18 Feb 2021 17:45:21 +0100 (CET) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id A76066386D for ; Thu, 18 Feb 2021 16:45:20 +0000 (UTC) Received: (qmail 44118 invoked by uid 500); 18 Feb 2021 16:45:20 -0000 Mailing-List: contact notifications-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list notifications@thrift.apache.org Received: (qmail 44108 invoked by uid 99); 18 Feb 2021 16:45:20 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Feb 2021 16:45:20 +0000 From: =?utf-8?q?GitBox?= To: notifications@thrift.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bthrift=5D_fishy_commented_on_pull_request_=232333?= =?utf-8?q?=3A_Cherry_picks_for_0=2E14=2E0_branch?= Message-ID: <161366671994.15632.6262708335399272920.asfpy@gitbox.apache.org> Date: Thu, 18 Feb 2021 16:45:19 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: fishy commented on pull request #2333: URL: https://github.com/apache/thrift/pull/2333#issuecomment-781479523 @Jens-G > Why do we need that as a hotfix in 0.14.0? Could you explain? These 2 commits fix 2 regressions in 0.14.0: 1. If you have an exception without any fields, for example: ```thrift exception LookMaNoFields {} ``` You can create an instance of `LookMaNoFields` in python code with thrift 0.12.0 python library without a problem (I'm not 100% sure if that works with 0.13.0 python library), but with 0.14.0 python library you'll get `TypeError: can't modify immutable instance` exception. #2330 fixed that. 2. If you have an endpoint with an arg with name `meta` (like the test case I added to `ThriftTest.thrift`), thrift compiler 0.14.0 generated go code won't compile because of name conflicts. This used to work in 0.13.0 and it's fixed in #2332. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org