From notifications-return-1038-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Wed Feb 17 20:52:47 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 2733C180633 for ; Wed, 17 Feb 2021 21:52:47 +0100 (CET) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 6614343BD5 for ; Wed, 17 Feb 2021 20:52:46 +0000 (UTC) Received: (qmail 20379 invoked by uid 500); 17 Feb 2021 20:52:46 -0000 Mailing-List: contact notifications-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list notifications@thrift.apache.org Received: (qmail 20370 invoked by uid 99); 17 Feb 2021 20:52:46 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Feb 2021 20:52:46 +0000 From: =?utf-8?q?GitBox?= To: notifications@thrift.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bthrift=5D_fishy_commented_on_a_change_in_pull_requ?= =?utf-8?q?est_=232315=3A_THRIFT-4914=3A_Make_TClient=2ECall_to_return_the_r?= =?utf-8?q?esponse_meta?= Message-ID: <161359516611.15632.13041936239405447564.asfpy@gitbox.apache.org> Date: Wed, 17 Feb 2021 20:52:46 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: fishy commented on a change in pull request #2315: URL: https://github.com/apache/thrift/pull/2315#discussion_r577935135 ########## File path: compiler/cpp/src/thrift/generate/t_go_generator.cc ########## @@ -2091,8 +2108,11 @@ void t_go_generator::generate_service_client(t_service* tservice) { std::string resultName = tmp("_result"); std::string resultType = publicize(method + "_result", true); f_types_ << indent() << "var " << resultName << " " << resultType << endl; - f_types_ << indent() << "if err = p.Client_().Call(ctx, \"" - << method << "\", &" << argsName << ", &" << resultName << "); err != nil {" << endl; + f_types_ << indent() << "var meta thrift.ResponseMeta" << endl; + f_types_ << indent() << "meta, err = p.Client_().Call(ctx, \"" + << method << "\", &" << argsName << ", &" << resultName << ")" << endl; + f_types_ << indent() << "p.SetLastResponseMeta_(meta)" << endl; + f_types_ << indent() << "if err != nil {" << endl; Review comment: Yes. Thanks for reporting. Preparing a PR to fix it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org