thrift-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [thrift] fishy commented on pull request #2333: Cherry picks for 0.14.0 branch
Date Thu, 18 Feb 2021 16:45:19 GMT

fishy commented on pull request #2333:
URL: https://github.com/apache/thrift/pull/2333#issuecomment-781479523


   @Jens-G 
   
   > Why do we need that as a hotfix in 0.14.0? Could you explain?
   
   These 2 commits fix 2 regressions in 0.14.0:
   
   1. If you have an exception without any fields, for example:
   
   ```thrift
   exception LookMaNoFields {}
   ```
   
   You can create an instance of `LookMaNoFields` in python code with thrift 0.12.0 python
library without a problem (I'm not 100% sure if that works with 0.13.0 python library), but
with 0.14.0 python library you'll get `TypeError: can't modify immutable instance` exception.
#2330 fixed that.
   
   2. If you have an endpoint with an arg with name `meta` (like the test case I added to
`ThriftTest.thrift`), thrift compiler 0.14.0 generated go code won't compile because of name
conflicts. This used to work in 0.13.0 and it's fixed in #2332.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message