thrift-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [thrift] kashirin-alex edited a comment on pull request #2318: THRIFT-5341: Fix Old-Style-Cast, Missing override and Possible noexcept
Date Sat, 13 Feb 2021 16:24:13 GMT

kashirin-alex edited a comment on pull request #2318:

   You can have additional insight on the changes there are with this commit:
    -By the way the byte-code (shared binary library) has remained of the same size.
    -While with 'cpp:moveable_types' `thrift -r --gen cpp:moveable_types` for the Service
the library grows from 1,224,976 to 1,273,392 bytes, a result of the Library includes the
Copy & Move instructions.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

View raw message