thrift-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [thrift] emmenlau commented on a change in pull request #2127: THRIFT-5187: Added Win32 support for domain sockets (AF_UNIX)
Date Fri, 12 Feb 2021 15:20:22 GMT

emmenlau commented on a change in pull request #2127:
URL: https://github.com/apache/thrift/pull/2127#discussion_r575299225



##########
File path: lib/cpp/src/thrift/transport/TSocket.cpp
##########
@@ -700,6 +689,10 @@ int TSocket::getPort() {
   return port_;
 }
 
+std::string TSocket::getPath() {

Review comment:
       Thanks, fixed in latest PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message