thrift-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [thrift] tylerchr commented on pull request #2288: THRIFT-5318: Update PHP thrift_protocol extension for PHP 8
Date Thu, 04 Feb 2021 00:55:24 GMT

tylerchr commented on pull request #2288:
URL: https://github.com/apache/thrift/pull/2288#issuecomment-772941445


   @rlerdorf Wow, thanks! Initially I had tried to include the default value in the stub file,
but was stymied by the resulting use of `ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE` in `arginfo.h`,
and that macro didn't exist in PHP 7. Your backward compat macros are exactly what I didn't
think of (or have the knowledge to write, frankly) to work past that.
   
   I went through each the differences in your version to understand and learn from them.
Thanks for the expert review. I pulled all of those changes in and added you as a co-author
on the squashed commit.
   
   One question: what is the notation you used in the name of your `Z4_OBJ_P` macro? In particular,
what does the `4` refer to?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message