thrift-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [thrift] BytedanceRPC commented on a change in pull request #2307: THRIFT-5337 Go set fields write improvement
Date Tue, 02 Feb 2021 06:58:55 GMT

BytedanceRPC commented on a change in pull request #2307:
URL: https://github.com/apache/thrift/pull/2307#discussion_r568363042



##########
File path: compiler/cpp/src/thrift/generate/t_go_generator.cc
##########
@@ -3463,6 +3550,112 @@ void t_go_generator::generate_serialize_list_element(ostream&
out, t_list* tlist
   generate_serialize_field(out, &efield, prefix);
 }
 
+/**
+ * Compares any type
+ */
+void t_go_generator::generate_go_equals(std::ostream& out,
+                                           t_type* ori_type,

Review comment:
       not sure is the `std::` making indentation looks weird. Indentations looks proper after
I remove `std::` and apply `clang-format`.
   To avoid unnecessary change, I only apply the output of clang-format on my changes in `compiler/cpp/src/thrift/generate/t_go_generator.cc`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message