From issues-return-44373-archive-asf-public=cust-asf.ponee.io@tez.apache.org Thu Jun 24 08:36:02 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id DED24180648 for ; Thu, 24 Jun 2021 10:36:01 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 1EC6B4165E for ; Thu, 24 Jun 2021 08:36:01 +0000 (UTC) Received: (qmail 87726 invoked by uid 500); 24 Jun 2021 08:36:00 -0000 Mailing-List: contact issues-help@tez.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tez.apache.org Delivered-To: mailing list issues@tez.apache.org Received: (qmail 87717 invoked by uid 99); 24 Jun 2021 08:36:00 -0000 Received: from mailrelay1-he-de.apache.org (HELO mailrelay1-he-de.apache.org) (116.203.21.61) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Jun 2021 08:36:00 +0000 Received: from jira2-he-de.apache.org (jira2-he-de.apache.org [168.119.33.54]) by mailrelay1-he-de.apache.org (ASF Mail Server at mailrelay1-he-de.apache.org) with ESMTPS id 27ED33E823 for ; Thu, 24 Jun 2021 08:36:00 +0000 (UTC) Received: from jira2-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira2-he-de.apache.org (ASF Mail Server at jira2-he-de.apache.org) with ESMTP id 07E34C800E8 for ; Thu, 24 Jun 2021 08:36:00 +0000 (UTC) Date: Thu, 24 Jun 2021 08:36:00 +0000 (UTC) From: "junbiao chen (Jira)" To: issues@tez.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (TEZ-4315) There is potential risk of ConcurrentModificationException when scheduling task for container MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TEZ-4315?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:all-tabpanel ] junbiao chen updated TEZ-4315: ------------------------------ Description:=20 When assigning task to container,YarnTaskSchedulerService need to=C2=A0trav= erse pending=C2=A0=C2=A0cookieContainerRequests(stored in LinkedHashSet) to= select one that mathing the container by calling method getMatchingRequest= WithoutPriority. In the meantime,=C2=A0YarnTaskSchedulerService will also r= emove the completed=C2=A0cookieContainerRequest from=C2=A0LinkedHashSet by = calling method removeTaskRequest.This may cause=C2=A0ConcurrentModificationException,becau= se=C2=A0=C2=A0LinkedHashSet is not=C2=A0thread-safe. =C2=A0 [https://github.com/apache/tez/pull/133] was: When assigning task to container,YarnTaskSchedulerService need to=C2=A0trav= erse pending=C2=A0=C2=A0cookieContainerRequests(stored in LinkedHashSet) to= select one that mathing the container by calling method getMatchingRequest= WithoutPriority. In the meantime,=C2=A0YarnTaskSchedulerService will also r= emove the completed=C2=A0cookieContainerRequest from=C2=A0LinkedHashSet by = calling method removeTaskRequest.This may cause=C2=A0ConcurrentModificationException,becau= se=C2=A0=C2=A0LinkedHashSet is not=C2=A0thread-safe. > There is potential risk of ConcurrentModificationException when schedulin= g task for container > -------------------------------------------------------------------------= -------------------- > > Key: TEZ-4315 > URL: https://issues.apache.org/jira/browse/TEZ-4315 > Project: Apache Tez > Issue Type: Improvement > Affects Versions: 0.9.1, 0.10.0 > Reporter: junbiao chen > Priority: Major > > When assigning task to container,YarnTaskSchedulerService need to=C2=A0tr= averse pending=C2=A0=C2=A0cookieContainerRequests(stored in LinkedHashSet) = to select one that mathing the container by calling method getMatchingReque= stWithoutPriority. In the meantime,=C2=A0YarnTaskSchedulerService will also= remove the completed=C2=A0cookieContainerRequest from=C2=A0LinkedHashSet b= y calling method > removeTaskRequest.This may cause=C2=A0ConcurrentModificationException,bec= ause=C2=A0=C2=A0LinkedHashSet is not=C2=A0thread-safe. > =C2=A0 > [https://github.com/apache/tez/pull/133] -- This message was sent by Atlassian Jira (v8.3.4#803005)