From issues-return-44339-archive-asf-public=cust-asf.ponee.io@tez.apache.org Thu Jun 10 06:06:52 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 4F21F18037A for ; Thu, 10 Jun 2021 08:06:52 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 82A0342532 for ; Thu, 10 Jun 2021 06:06:51 +0000 (UTC) Received: (qmail 10120 invoked by uid 500); 10 Jun 2021 06:06:51 -0000 Mailing-List: contact issues-help@tez.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tez.apache.org Delivered-To: mailing list issues@tez.apache.org Received: (qmail 10111 invoked by uid 99); 10 Jun 2021 06:06:51 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Jun 2021 06:06:51 +0000 From: =?utf-8?q?GitBox?= To: issues@tez.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Btez=5D_abstractdog_commented_on_pull_request_=2395?= =?utf-8?q?=3A_TEZ-4275=3A_Use_Google_Guava_Intern_Facility?= Message-ID: <162330521102.15571.3081244829490925591.asfpy@gitbox.apache.org> Date: Thu, 10 Jun 2021 06:06:51 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: abstractdog commented on pull request #95: URL: https://github.com/apache/tez/pull/95#issuecomment-858334508 hi @belugabehr! I just ran through the history, memory/speed improvement is promising, also you removed every questioned part, so this looks good to me it's a +1 from my side -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org