tez-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (TEZ-3985) Correctness: Throw a clear exception for DMEs sent during cleanup
Date Tue, 26 Jan 2021 06:20:00 GMT

    [ https://issues.apache.org/jira/browse/TEZ-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271895#comment-17271895
] 

Hadoop QA commented on TEZ-3985:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 30s{color} | {color:blue}
Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  0s{color} |
{color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m  0s{color}
| {color:green} The patch appears to include 1 new or modified test files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 40s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m  7s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 14s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 29s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 35s{color} |
{color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  4m 53s{color} | {color:blue}
Used deprecated FindBugs config; considering switching to SpotBugs. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m 49s{color} | {color:red}
root in master has 2 extant findbugs warnings. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 15s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 11s{color} | {color:red}
tez-runtime-internals in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 37s{color} | {color:red}
root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 11s{color} | {color:red}
tez-runtime-internals in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 18s{color} | {color:red}
root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 11s{color} | {color:red}
tez-runtime-internals in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 18s{color} | {color:red}
root in the patch failed. {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  0m 11s{color}
| {color:orange} tez-runtime-internals: The patch generated 3 new + 73 unchanged - 0 fixed
= 76 total (was 73) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  0m 29s{color}
| {color:orange} root: The patch generated 3 new + 78 unchanged - 0 fixed = 81 total (was
78) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  1s{color} | {color:green}
The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 13s{color} | {color:red}
tez-runtime-internals generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  1m 23s{color} | {color:red}
root generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 11s{color} | {color:red}
tez-runtime-internals in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 54s{color} | {color:red}
root in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 49s{color} | {color:green}
tez-api in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 12s{color} | {color:red}
tez-runtime-internals in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  2m  9s{color} | {color:red}
root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 29s{color} | {color:red}
The patch generated 13 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 30m 53s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/92/artifact/out/Dockerfile
|
| JIRA Issue | TEZ-3985 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12958096/TEZ-3985.4.patch
|
| Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs findbugs checkstyle
|
| uname | Linux 50623aab9d87 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 7374b69ed |
| Default Java | Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 |
| findbugs | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/92/artifact/out/branch-findbugs-root-warnings.html
|
| mvninstall | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/92/artifact/out/patch-mvninstall-tez-runtime-internals.txt
|
| mvninstall | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/92/artifact/out/patch-mvninstall-root.txt
|
| compile | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/92/artifact/out/patch-compile-tez-runtime-internals.txt
|
| compile | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/92/artifact/out/patch-compile-root.txt
|
| javac | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/92/artifact/out/patch-compile-tez-runtime-internals.txt
|
| javac | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/92/artifact/out/patch-compile-root.txt
|
| checkstyle | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/92/artifact/out/diff-checkstyle-tez-runtime-internals.txt
|
| checkstyle | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/92/artifact/out/diff-checkstyle-root.txt
|
| javadoc | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/92/artifact/out/diff-javadoc-javadoc-tez-runtime-internals.txt
|
| javadoc | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/92/artifact/out/diff-javadoc-javadoc-root.txt
|
| findbugs | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/92/artifact/out/patch-findbugs-tez-runtime-internals.txt
|
| findbugs | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/92/artifact/out/patch-findbugs-root.txt
|
| unit | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/92/artifact/out/patch-unit-tez-runtime-internals.txt
|
| unit | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/92/artifact/out/patch-unit-root.txt
|
|  Test Results | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/92/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/92/artifact/out/patch-asflicense-problems.txt
|
| Max. process+thread count | 459 (vs. ulimit of 5500) |
| modules | C: tez-api tez-runtime-internals . U: . |
| Console output | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/92/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |


This message was automatically generated.



> Correctness: Throw a clear exception for DMEs sent during cleanup
> -----------------------------------------------------------------
>
>                 Key: TEZ-3985
>                 URL: https://issues.apache.org/jira/browse/TEZ-3985
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Gopal Vijayaraghavan
>            Assignee: Jaume M
>            Priority: Major
>         Attachments: TEZ-3985.1.patch, TEZ-3985.2.patch, TEZ-3985.3.patch, TEZ-3985.3.patch,
TEZ-3985.4.patch, TEZ-3985.5.patch
>
>
> If a DME is sent during cleanup, that implies that the .close() of the LogicalIOProcessorRuntimeTask
did not succeed and therefore these events are an error condition.
> These events should not be sent and more importantly should be received by the AM.
> Throw a clear exception, in case of this & allow the developers to locate the extraneous
event from the backtrace.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message