tez-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "TezQA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (TEZ-3860) JDK9: ReflectionUtils may not use URLClassLoader
Date Thu, 07 Nov 2019 11:13:01 GMT

    [ https://issues.apache.org/jira/browse/TEZ-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969174#comment-16969174
] 

TezQA commented on TEZ-3860:
----------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 20s{color} | {color:blue}
Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m  0s{color}
| {color:green} The patch appears to include 1 new or modified test files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 19s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 27s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 54s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 49s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 39s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  0s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 19s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 56s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 54s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 54s{color} | {color:green}
the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  0m 22s{color}
| {color:orange} tez-api: The patch generated 1 new + 16 unchanged - 0 fixed = 17 total (was
16) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 55s{color} | {color:red}
tez-api generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  3s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 49s{color} | {color:green}
tez-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m 50s{color} | {color:green}
tez-dag in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 38s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m  4s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:tez-api |
|  |  org.apache.tez.common.TezClassLoader.<static initializer for TezClassLoader>()
creates a org.apache.tez.common.TezClassLoader classloader, which should be performed within
a doPrivileged block  At TezClassLoader.java:a org.apache.tez.common.TezClassLoader classloader,
which should be performed within a doPrivileged block  At TezClassLoader.java:[line 26] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.4 Server=19.03.4 Image:yetus/tez:d4a62deee |
| JIRA Issue | TEZ-3860 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12985194/TEZ-3860.02.patch
|
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  checkstyle  compile
 |
| uname | Linux 2bd748e3edaf 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | master / b99c7ce |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_222 |
| findbugs | v3.0.1 |
| checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/193/artifact/out/diff-checkstyle-tez-api.txt
|
| findbugs | https://builds.apache.org/job/PreCommit-TEZ-Build/193/artifact/out/new-findbugs-tez-api.html
|
|  Test Results | https://builds.apache.org/job/PreCommit-TEZ-Build/193/testReport/ |
| Max. process+thread count | 230 (vs. ulimit of 5500) |
| modules | C: tez-api tez-dag U: . |
| Console output | https://builds.apache.org/job/PreCommit-TEZ-Build/193/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> JDK9: ReflectionUtils may not use URLClassLoader
> ------------------------------------------------
>
>                 Key: TEZ-3860
>                 URL: https://issues.apache.org/jira/browse/TEZ-3860
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Zoltan Haindrich
>            Assignee: László Bodor
>            Priority: Major
>         Attachments: TEZ-3860.01.patch, TEZ-3860.02.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The following code
> https://github.com/apache/tez/blob/master/tez-api/src/main/java/org/apache/tez/common/ReflectionUtils.java#L125
> is not compatible with JDK9 since the classloader is an AppClassLoader
> causes exceptions like this:
> {code}
> java.lang.ClassCastException: java.base/jdk.internal.loader.ClassLoaders$AppClassLoader
cannot be cast to java.base/java.net.URLClassLoader
> 	at org.apache.tez.common.ReflectionUtils.addResourcesToSystemClassLoader(ReflectionUtils.java:125)
~[tez-api-0.9.0.jar:0.9.0]
> 	at org.apache.tez.dag.utils.RelocalizationUtils.addUrlsToClassPath(RelocalizationUtils.java:57)
~[tez-common-0.9.0.jar:0.9.0]
> 	at org.apache.tez.dag.app.dag.impl.DAGImpl$StartTransition.transition(DAGImpl.java:1793)
~[tez-dag-0.9.0.jar:0.9.0]
> 	at org.apache.tez.dag.app.dag.impl.DAGImpl$StartTransition.transition(DAGImpl.java:1776)
~[tez-dag-0.9.0.jar:0.9.0]
> 	at org.apache.hadoop.yarn.state.StateMachineFactory$SingleInternalArc.doTransition(StateMachineFactory.java:362)
~[hadoop-yarn-common-2.8.1.jar:?]
> 	at org.apache.hadoop.yarn.state.StateMachineFactory.doTransition(StateMachineFactory.java:302)
~[hadoop-yarn-common-2.8.1.jar:?]
> 	at org.apache.hadoop.yarn.state.StateMachineFactory.access$300(StateMachineFactory.java:46)
~[hadoop-yarn-common-2.8.1.jar:?]
> 	at org.apache.hadoop.yarn.state.StateMachineFactory$InternalStateMachine.doTransition(StateMachineFactory.java:448)
~[hadoop-yarn-common-2.8.1.jar:?]
> 	at org.apache.tez.state.StateMachineTez.doTransition(StateMachineTez.java:59) ~[tez-dag-0.9.0.jar:0.9.0]
> 	at org.apache.tez.dag.app.dag.impl.DAGImpl.handle(DAGImpl.java:1156) [tez-dag-0.9.0.jar:0.9.0]
> 	at org.apache.tez.dag.app.dag.impl.DAGImpl.handle(DAGImpl.java:147) [tez-dag-0.9.0.jar:0.9.0]
> 	at org.apache.tez.dag.app.DAGAppMaster$DagEventDispatcher.handle(DAGAppMaster.java:2251)
[tez-dag-0.9.0.jar:0.9.0]
> 	at org.apache.tez.dag.app.DAGAppMaster$DagEventDispatcher.handle(DAGAppMaster.java:2242)
[tez-dag-0.9.0.jar:0.9.0]
> 	at org.apache.tez.common.AsyncDispatcher.dispatch(AsyncDispatcher.java:180) [tez-common-0.9.0.jar:0.9.0]
> 	at org.apache.tez.common.AsyncDispatcher$1.run(AsyncDispatcher.java:115) [tez-common-0.9.0.jar:0.9.0]
> 	at java.base/java.lang.Thread.run(Thread.java:844) [?:?]
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message