From issues-return-39618-archive-asf-public=cust-asf.ponee.io@tez.apache.org Wed Aug 22 21:58:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 20E80180677 for ; Wed, 22 Aug 2018 21:58:03 +0200 (CEST) Received: (qmail 29481 invoked by uid 500); 22 Aug 2018 19:58:03 -0000 Mailing-List: contact issues-help@tez.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tez.apache.org Delivered-To: mailing list issues@tez.apache.org Received: (qmail 29460 invoked by uid 99); 22 Aug 2018 19:58:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Aug 2018 19:58:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id A91D41A0877 for ; Wed, 22 Aug 2018 19:58:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id zgzNkOn8LP7M for ; Wed, 22 Aug 2018 19:58:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 476F15F431 for ; Wed, 22 Aug 2018 19:58:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 864D7E0E87 for ; Wed, 22 Aug 2018 19:58:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2FE742468F for ; Wed, 22 Aug 2018 19:58:00 +0000 (UTC) Date: Wed, 22 Aug 2018 19:58:00 +0000 (UTC) From: "Sergey Shelukhin (JIRA)" To: issues@tez.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TEZ-3980) ShuffleRunner: the wake loop needs to check for shutdown MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TEZ-3980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589304#comment-16589304 ] Sergey Shelukhin commented on TEZ-3980: --------------------------------------- +1 non-binding > ShuffleRunner: the wake loop needs to check for shutdown > -------------------------------------------------------- > > Key: TEZ-3980 > URL: https://issues.apache.org/jira/browse/TEZ-3980 > Project: Apache Tez > Issue Type: Bug > Reporter: Gopal V > Assignee: Gopal V > Priority: Major > Attachments: TEZ-3980.1.patch > > > In the ShuffleRunner threads, there's a loop which does not terminate if the task threads get killed. > {code} > while ((runningFetchers.size() >= numFetchers || pendingHosts.isEmpty()) > && numCompletedInputs.get() < numInputs) { > inputContext.notifyProgress(); > boolean ret = wakeLoop.await(1000, TimeUnit.MILLISECONDS); > } > {code} > The wakeLoop signal does not exit this out of the loop and is missing a break for shut-down. -- This message was sent by Atlassian JIRA (v7.6.3#76005)