From issues-return-39604-archive-asf-public=cust-asf.ponee.io@tez.apache.org Fri Aug 17 00:00:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 826AE180675 for ; Fri, 17 Aug 2018 00:00:04 +0200 (CEST) Received: (qmail 54878 invoked by uid 500); 16 Aug 2018 22:00:03 -0000 Mailing-List: contact issues-help@tez.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tez.apache.org Delivered-To: mailing list issues@tez.apache.org Received: (qmail 54869 invoked by uid 99); 16 Aug 2018 22:00:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Aug 2018 22:00:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 131B41A1FBF for ; Thu, 16 Aug 2018 22:00:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Mosmh-4Lm9eI for ; Thu, 16 Aug 2018 22:00:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 9EE2D5F4AA for ; Thu, 16 Aug 2018 22:00:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9AB8EE0E1D for ; Thu, 16 Aug 2018 22:00:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3CCAE23F98 for ; Thu, 16 Aug 2018 22:00:00 +0000 (UTC) Date: Thu, 16 Aug 2018 22:00:00 +0000 (UTC) From: "TezQA (JIRA)" To: issues@tez.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TEZ-3979) Redact configuration when it's being logged, sent to the timeline server or displayed in some way MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TEZ-3979?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D165831= 02#comment-16583102 ]=20 TezQA commented on TEZ-3979: ---------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest a= ttachment http://issues.apache.org/jira/secure/attachment/12935914/TEZ-3979.1.patch against master revision 4b9a7be. {color:green}+1 @author{color}. The patch does not contain any @author= tags. {color:green}+1 tests included{color}. The patch appears to include 2 = new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the = total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning mess= ages. {color:green}+1 findbugs{color}. The patch does not introduce any new = Findbugs (version 3.0.1) warnings. {color:green}+1 release audit{color}. The applied patch does not incre= ase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in = : org.apache.tez.dag.api.TestTezConfiguration Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/2893//testR= eport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2893//con= sole This message is automatically generated. > Redact configuration when it's being logged, sent to the timeline server = or displayed in some way > -------------------------------------------------------------------------= ------------------------ > > Key: TEZ-3979 > URL: https://issues.apache.org/jira/browse/TEZ-3979 > Project: Apache Tez > Issue Type: Bug > Components: UI > Affects Versions: 0.9.1 > Reporter: Jaume M > Assignee: Jaume M > Priority: Major > Attachments: TEZ-3979.1.patch > > > The configuration is being logged in some places like=C2=A0[here|https://= github.com/apache/tez/blob/90c8195de0ddee9da3d4cd07519c8e287c85ad50/tez-dag= /src/main/java/org/apache/tez/dag/history/utils/DAGUtils.java#L508]=C2=A0an= d [here|https://github.com/apache/tez/blob/90c8195de0ddee9da3d4cd07519c8e28= 7c85ad50/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/processor/MRT= ask.java#L177]=C2=A0. We should do something like [what it's done in the ha= doop code base|https://github.com/apache/hadoop/blob/d951af22b42a22c09cfeec= d3c866d5f1cd412120/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-= mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/J= obHistoryEventHandler.java#L558] and redact the properties held in=C2=A0{{m= apreduce.job.redacted-properties.}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)