tez-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Eagles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEZ-3982) DAGAppMaster and tasks should not report negative or invalid progress
Date Tue, 28 Aug 2018 18:31:00 GMT

    [ https://issues.apache.org/jira/browse/TEZ-3982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595408#comment-16595408
] 

Jonathan Eagles commented on TEZ-3982:
--------------------------------------

Please move the calculation of from DAGAppMaster to DAGImpl to keep the logic in one place.
In addition to checking for > 0.0f please add check and corresponding tests for less than
0.0f since it is the frameworks' job to keep progress between 0.0f and 1.0f. A related Jira
is https://issues.apache.org/jira/browse/MAPREDUCE-5671 which is more extreme in approach.
I think a simple check for between 0.0f and 1.0f is sufficient.

> DAGAppMaster and tasks should not report negative or invalid progress
> ---------------------------------------------------------------------
>
>                 Key: TEZ-3982
>                 URL: https://issues.apache.org/jira/browse/TEZ-3982
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.9.1, 0.10.0
>            Reporter: Kuhu Shukla
>            Assignee: Kuhu Shukla
>            Priority: Major
>         Attachments: TEZ-3982.001.patch
>
>
> AM fails (AMRMClient expects non negative progress) if any component reports invalid
or -ve progress, DagAppMaster/Tasks should check and report accordingly to allow the AM to
execute.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message