tez-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "TezQA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEZ-3981) UnorderedPartitionedKVWriter.getInitialMemoryRequirement may return negative memory
Date Mon, 20 Aug 2018 22:11:00 GMT

    [ https://issues.apache.org/jira/browse/TEZ-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586580#comment-16586580
] 

TezQA commented on TEZ-3981:
----------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12936325/TEZ-3981.1.patch
  against master revision 4b9a7be.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
3.0.1) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in :
                   org.apache.tez.dag.app.rm.TestTaskScheduler

Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/2897//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2897//console

This message is automatically generated.


> UnorderedPartitionedKVWriter.getInitialMemoryRequirement may return negative memory
> -----------------------------------------------------------------------------------
>
>                 Key: TEZ-3981
>                 URL: https://issues.apache.org/jira/browse/TEZ-3981
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.9.1
>            Reporter: Jaume M
>            Assignee: Jaume M
>            Priority: Major
>         Attachments: TEZ-3981.1.patch
>
>
> The reason for this is because [here|https://github.com/apache/tez/blob/4b9a7be1b98cff00c44e7d3ffb2486bb59ca6804/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/writers/UnorderedPartitionedKVWriter.java#L678]
first we shift the int, and then we assign it to the long, therefore if the int is bigger
than {{2^12}} when shifting {{20}} it becomes a negative value. We should cast to long and
then do the shift. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message