tez-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kuhu Shukla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEZ-3980) ShuffleRunner: the wake loop needs to check for shutdown
Date Thu, 16 Aug 2018 14:25:00 GMT

    [ https://issues.apache.org/jira/browse/TEZ-3980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16582598#comment-16582598
] 

Kuhu Shukla commented on TEZ-3980:
----------------------------------

Good catch [~gopalv].Do we need an equivalent change in ShuffleScheduler as well? (The ordered
case)

> ShuffleRunner: the wake loop needs to check for shutdown
> --------------------------------------------------------
>
>                 Key: TEZ-3980
>                 URL: https://issues.apache.org/jira/browse/TEZ-3980
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Gopal V
>            Assignee: Gopal V
>            Priority: Major
>         Attachments: TEZ-3980.1.patch
>
>
> In the ShuffleRunner threads, there's a loop which does not terminate if the task threads
get killed.
> {code}
>           while ((runningFetchers.size() >= numFetchers || pendingHosts.isEmpty())
>               && numCompletedInputs.get() < numInputs) {
>             inputContext.notifyProgress();
>             boolean ret = wakeLoop.await(1000, TimeUnit.MILLISECONDS);
>           }
> {code}
> The wakeLoop signal does not exit this out of the loop and is missing a break for shut-down.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message