tez-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "TezQA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEZ-3979) Redact configuration when it's being logged, sent to the timeline server or displayed in some way
Date Thu, 16 Aug 2018 22:00:00 GMT

    [ https://issues.apache.org/jira/browse/TEZ-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16583102#comment-16583102
] 

TezQA commented on TEZ-3979:
----------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12935914/TEZ-3979.1.patch
  against master revision 4b9a7be.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
3.0.1) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in :
                   org.apache.tez.dag.api.TestTezConfiguration

Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/2893//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2893//console

This message is automatically generated.


> Redact configuration when it's being logged, sent to the timeline server or displayed
in some way
> -------------------------------------------------------------------------------------------------
>
>                 Key: TEZ-3979
>                 URL: https://issues.apache.org/jira/browse/TEZ-3979
>             Project: Apache Tez
>          Issue Type: Bug
>          Components: UI
>    Affects Versions: 0.9.1
>            Reporter: Jaume M
>            Assignee: Jaume M
>            Priority: Major
>         Attachments: TEZ-3979.1.patch
>
>
> The configuration is being logged in some places like [here|https://github.com/apache/tez/blob/90c8195de0ddee9da3d4cd07519c8e287c85ad50/tez-dag/src/main/java/org/apache/tez/dag/history/utils/DAGUtils.java#L508] and
[here|https://github.com/apache/tez/blob/90c8195de0ddee9da3d4cd07519c8e287c85ad50/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/processor/MRTask.java#L177] .
We should do something like [what it's done in the hadoop code base|https://github.com/apache/hadoop/blob/d951af22b42a22c09cfeecd3c866d5f1cd412120/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java#L558]
and redact the properties held in {{mapreduce.job.redacted-properties.}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message