Mailing-List: contact issues-help@tez.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tez.apache.org
Date: Tue, 6 Jun 2017 21:53:18 +0000 (UTC)
From: "TezQA (JIRA)" <jira@apache.org>
To: issues@tez.apache.org
Message-ID: <JIRA.13077775.1496777233000.11267.1496785998434@Atlassian.JIRA>
In-Reply-To: <JIRA.13077775.1496777233000@Atlassian.JIRA>
References: <JIRA.13077775.1496777233000@Atlassian.JIRA> <JIRA.13077775.1496777233595@jira-lw-us.apache.org>
Subject: [jira] [Commented] (TEZ-3753) Improve error message in IFile for
 buffer length overflow
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 06 Jun 2017 21:53:25 -0000


    [ https://issues.apache.org/jira/browse/TEZ-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039723#comment-16039723 ] 

TezQA commented on TEZ-3753:
----------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12871685/tez-3753.001.patch
  against master revision 29b45bc.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in :
                   org.apache.tez.analyzer.TestAnalyzer

Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/2517//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2517//console

This message is automatically generated.

> Improve error message in IFile for buffer length overflow
> ---------------------------------------------------------
>
>                 Key: TEZ-3753
>                 URL: https://issues.apache.org/jira/browse/TEZ-3753
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.7.1
>            Reporter: Muhammad Samir Khan
>            Assignee: Muhammad Samir Khan
>         Attachments: tez-3753.001.patch
>
>
> When a record size is too big and the byte array doubling expansion crosses 2G the array size overflows and becomes negative. It would be good to fail the code paths saying record is too big so that error is easy to understand for users.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)