Mailing-List: contact issues-help@tez.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tez.apache.org
Date: Thu, 1 Jun 2017 15:32:04 +0000 (UTC)
From: "Kuhu Shukla (JIRA)" <jira@apache.org>
To: issues@tez.apache.org
Message-ID: <JIRA.13074857.1495722738000.342444.1496331124143@Atlassian.JIRA>
In-Reply-To: <JIRA.13074857.1495722738000@Atlassian.JIRA>
References: <JIRA.13074857.1495722738000@Atlassian.JIRA> <JIRA.13074857.1495722738779@jira-lw-us.apache.org>
Subject: [jira] [Commented] (TEZ-3741) Tez outputs should free memory when
 closed
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 01 Jun 2017 15:32:08 -0000


    [ https://issues.apache.org/jira/browse/TEZ-3741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033163#comment-16033163 ] 

Kuhu Shukla commented on TEZ-3741:
----------------------------------

Thanks [~jlowe] for the updated patch!

I should have caught this sooner but may be we need a similar change for PipelinedSorter (SortSpan.close()) for completeness. Thoughts?

Also, 
{code}
 boolean isClosed() {
    return kvbuffer == null && kvmeta == null;
  }
{code}

Do we want it marked as @VisibleForTesting or have it available for other src/main files in the package?

> Tez outputs should free memory when closed
> ------------------------------------------
>
>                 Key: TEZ-3741
>                 URL: https://issues.apache.org/jira/browse/TEZ-3741
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.7.1, 0.9.0
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>         Attachments: TEZ-3741.001.patch, TEZ-3741.002.patch
>
>
> Memory buffers aren't being released as quickly as they could be, e.g.: DefaultSorter is holding onto the very large kvbuffer byte array even after close() is called, and Ordered and Unordered outputs should remove references to sorter and kvWriter in their close.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)